Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong State for Samsung #1447

Closed
yaroshd81 opened this issue Mar 29, 2021 · 2 comments · Fixed by #1448
Closed

Wrong State for Samsung #1447

yaroshd81 opened this issue Mar 29, 2021 · 2 comments · Fixed by #1448
Assignees
@crankyoldgit
Labels
bug

Comments

@yaroshd81
Copy link

You have 2 function for return results state AC:

  1. IRAcUtils::resultAcToString
  2. IRAcUtils::decodeToState
    If used 1 function after recived command, we have nice result:
    resultAcToString:Power: On, Mode: 1 (Cool), Temp: 22C, Fan: 4 (Med), Swing: Off, Beep: Off, Clean: Off, Quiet: Off, Powerful: Off, Breeze: Off, Light: Off, Ion: Off
    But if used 2 function, we have bad results, because Mode: 0 (Auto), Temp: 16C, Fan: 0 (Auto) (All parameters have 0, because Temp: 16C = (int)0)
    I fixed problem when analize 1 function with 2:
    ac.setRaw(decode->state, decode->bits / 8);//This code in 1 function where all good working //ac.setRaw(decode->state);//This code in 2 function where not working
@crankyoldgit crankyoldgit self-assigned this Mar 30, 2021
crankyoldgit added a commit that referenced this issue Mar 30, 2021
@crankyoldgit
[BUG] Fix IRAcUtils::decodeToState() for different length Samsung msgs
531d9c7 
Need to pass byte length to `IRSamsungAc::setRaw()` to handle normal & **extended** messages.

Kudos to @yaroshd81 for finding the bug, and offering the solution.

Fixes #1447
@crankyoldgit crankyoldgit mentioned this issue Mar 30, 2021
Merged
@crankyoldgit
Copy link
Owner

Thanks for the bug report and the fix. I concur. I clearly oopsed when I wrote that.

I also checked for other Protocols in IRAcUtils::resultAcToString that also use the bit length, and they are all present in IRAcUtils::decodeToState, so it looks like that's the only one I missed. Phew.

crankyoldgit added a commit that referenced this issue Mar 30, 2021
@crankyoldgit
[BUG] Fix IRAcUtils::decodeToState() for different length Samsung m…
cd8d600 
…sgs (#1448)

Need to pass byte length to `IRSamsungAc::setRaw()` to handle normal & **extended** messages.

Kudos to @yaroshd81 for finding the bug, and offering the solution.

Fixes #1447
crankyoldgit added a commit that referenced this issue Apr 17, 2021
@crankyoldgit
v2.7.17 release
31133f8 
_v2.7.17 (20210418)_
**[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
@crankyoldgit crankyoldgit mentioned this issue Apr 17, 2021
Merged
crankyoldgit added a commit that referenced this issue Apr 18, 2021
@crankyoldgit
v2.7.17 release (#1461)
6a94b44 
## _v2.7.17 (20210418)_
### **[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
crankyoldgit added a commit that referenced this issue Apr 19, 2021
@crankyoldgit
v2.7.17 re-release
cc5b15d 
_v2.7.17 (20210420)_
**[News]**
- The library now supports 100 IR protocols! \o/

**[Bug Fixes]**
- Fix `IRAcUtils::decodeToState()` for different length Samsung msgs (#1447 #1448)
- Fix issues with installing the library under the Arduino IDE on Win10 & OSX (#1451 #1464)

**[Features]**
- Fujitsu: Add support for `ARREW4E` model. (#1455 #1456)
- Experimental detailed support for Truma A/Cs. (#1440 #1449)

**[Misc]**
- Fix Arduino library linter issues. (#1451 #1452 #1453 #1460)
- Reduce the library's zip download size. (#1451 #1463)
- An experiment in using Github Actions to do some of the CI work. (#1462)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned earlier have been included in the latest release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Fix IRAcUtils::decodeToState() for different length Samsung msgs crankyoldgit/IRremoteESP8266
2 participants
@crankyoldgit @yaroshd81