-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another variant for LG swing command to add. (request) #1770
Comments
Can you please give us your brand/model numbers for your remote and A/C unit? |
Remote is 6711A20083V if I use IRsend with { "Protocol":"LG","Bits": 28,"Data": 0x8810001 } it works but I am trying to send commands with IRHVAC and SwingV option but I cant make it work. I am testing it from tasmota console btw. IRHVAC {"Vendor":"LG","Model":1,"Mode":"Fan","Power":"On","Celsius":"On","Temp":25,"FanSpeed":"Min","SwingV":"Auto","SwingH":"Off","Quiet":"Off","Turbo":"Off","Econo":"Off","Light":"Off","Filter":"Off","Clean":"Off","Beep":"Off","Sleep":-1} IRHVAC {"Vendor":"LG","Model":1,"Mode":"Fan","Power":"On","Celsius":"On","Temp":25,"FanSpeed":"Min","SwingV":"Off","SwingH":"Off","Quiet":"Off","Turbo":"Off","Econo":"Off","Light":"Off","Filter":"Off","Clean":"Off","Beep":"Off","Sleep":-1} |
The brand is LG too? |
LG yes |
Sorry, another question. Is that the only swing command your remote produces? |
Yes, 0x8810001 for both swing On and Swing Off (toggle) |
* Detect swingv toggle messages and set appropriate model. * Allow sending of swingv toggle messages. * Update supported models info * Various collateral updates. * Minor code cleanup. * Supporting unit tests. * Needs testing on a real device. Fixes #1770
@crackn Can you please download and test the following branch: https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1770 You will need to set the Please also test the remote with IRrecvDumpV2 or V3, it should detect as:
When it gets your swing toggle message code, otherwise it should be Model: 1 / GE6711AR2853M |
ok, I will test it and return to you asap. thanks btw, I was doing some tests and noted that some comands are identified as diferent controllers. so there are some bugs in the LG detection code, i will do more tests to give you feedback about this ok. |
Model Detection is based on a per message basis. Some messages are unique to a model, so it's detected as the correct model. And some messages are common to multiple models, so it reports them as a less specific (base) model. |
here are the results: the swing function works great. *** LG SWING-V toggle command (remote LG6711A20083V) OK! and below are some other functions not implemented. *** LG SWING-H toggle command (remote LG6711A20083V) *** LG JET-COOL ON command (remote LG6711A20083V) *** LG AUTO-CLEAN ON command (remote LG6711A20083V) *** LG AUTO-CLEAN OFF command (remote LG6711A20083V) *** LG PLASMA-ION ON command (remote LG6711A20083V) *** LG PLASMA-ION OFF command (remote LG6711A20083V) it would be great and easy to implement if all functions belonged to the same mode but I understand your point. thanks. |
Please create a new issue for the extra features you're now suggesting.
That is to be expected. When using the interface that you're using, it will try to set the A/C to all the desired settings each time to ensure the device is completely in the desired operational mode. |
Ok, no problem, I will do that. thanks for the fast solution. |
* Detect swingv toggle messages and set appropriate model. * Allow sending of swingv toggle messages. * Update supported models info * Various collateral updates. * Minor code cleanup. * Supporting unit tests. * Confirmed working on real device by requester. Fixes #1770
_v2.8.2 (20220314)_ **[Bug Fixes]** - ESP32-C3: Fix reboot/crashes on ESP32-C3s when receiving. (#1768 #1751) **[Features]** - HITACHI_AC296: Add `IRac` class support & tests. (#1776 #1758 #1757) - Support for Hitachi RAS-70YHA3 (remote RAR-3U3) (#1758 #1757) - LG: Add Swing Toggle support for Model `LG6711A20083V` (#1771 #1770) - IRMQTTServer: add `MQTT_SERVER_AUTODETECT_ENABLE` via mqtt mDNS (#1769) - Experimental basic support for Kelon 168 bit / 21 byte protocol. (#1747 #1745 #1744) - MitsubishiAC: Tweak repeat gap timing. (#1760 #1759) - Gree YAP0F8 (Detected as Kelvinator) vertical position set support (#1756) - Make KELON (48 bit) protocol decoding stricter. (#1746 #1744) - IRMQTTServer V1.6.1 (#1740 #1739 #1729) - HITACHI_AC264: Add minimal detailed support. (#1735 #1729) - LG2: Improve Light toggle msg handling. (#1738 #1737) - MIDEA: Add support for Quiet, Clean & Freeze Protect controls. (#1734 #1733) - Add basic support for HITACHI_AC264 264bit protocol. (#1730 #1729) - ESP32-C3: Work around for some C3 specific compiler issues again. (#1732 #1695) **[Misc]** - MIDEA: Update supported devices (#1774 #1773 #1716) - Update devices supported by ELECTRA_AC (#1766 #1765) - Improve documentation for `encodePioneer()` (#1761 #1749) - Update (un)supported DAIKIN128 devices. (#1752) - Refactor `decodeCOOLIX()` code & add another test case. (#1750 #1748) - Simplify code based on state_t being initialised by default. (#1736 #1699) - Add comments to help Teknopoint users. (#1731 #1728) - Fix library version string calculation. (#1727 #1725) - Confirm we can reproduce `TurnOnFujitsuAC.ino` via IRac/IRMQTTServer. (#1726 #1701)
##_v2.8.2 (20220314)_ **[Bug Fixes]** - ESP32-C3: Fix reboot/crashes on ESP32-C3s when receiving. (#1768 #1751) **[Features]** - HITACHI_AC296: Add `IRac` class support & tests. (#1776 #1758 #1757) - Support for Hitachi RAS-70YHA3 (remote RAR-3U3) (#1758 #1757) - LG: Add Swing Toggle support for Model `LG6711A20083V` (#1771 #1770) - IRMQTTServer: add `MQTT_SERVER_AUTODETECT_ENABLE` via mqtt mDNS (#1769) - Experimental basic support for Kelon 168 bit / 21 byte protocol. (#1747 #1745 #1744) - MitsubishiAC: Tweak repeat gap timing. (#1760 #1759) - Gree YAP0F8 (Detected as Kelvinator) vertical position set support (#1756) - Make KELON (48 bit) protocol decoding stricter. (#1746 #1744) - IRMQTTServer V1.6.1 (#1740 #1739 #1729) - HITACHI_AC264: Add minimal detailed support. (#1735 #1729) - LG2: Improve Light toggle msg handling. (#1738 #1737) - MIDEA: Add support for Quiet, Clean & Freeze Protect controls. (#1734 #1733) - Add basic support for HITACHI_AC264 264bit protocol. (#1730 #1729) - ESP32-C3: Work around for some C3 specific compiler issues again. (#1732 #1695) **[Misc]** - MIDEA: Update supported devices (#1774 #1773 #1716) - Update devices supported by ELECTRA_AC (#1766 #1765) - Improve documentation for `encodePioneer()` (#1761 #1749) - Update (un)supported DAIKIN128 devices. (#1752) - Refactor `decodeCOOLIX()` code & add another test case. (#1750 #1748) - Simplify code based on state_t being initialised by default. (#1736 #1699) - Add comments to help Teknopoint users. (#1731 #1728) - Fix library version string calculation. (#1727 #1725) - Confirm we can reproduce `TurnOnFujitsuAC.ino` via IRac/IRMQTTServer. (#1726 #1701)
FYI, the changes mentioned above have now been included in the new v2.8.2 release of the library. |
Hi, @crankyoldgit
I would like to know if its possible to add another command to turn on and off the swing function on LG (older model)
this is the code that is working for turn on and turn off swing: { "Protocol":"LG","Bits": 28,"Data": 0x8810001 }
I noted that in LG_ir.h all the swing variants are 0x8813xxx and none of that works on this older model of LG.
thanks in adv.
The text was updated successfully, but these errors were encountered: