The implementation and declaration of some functions differs from the function call

[MarkKoshelev]

I encountered this when my AC Haier was not working correctly.
src/IRac.cpp
1460: void IRac::haier176(IRHaierAC176 *ac, const haier_ac176_remote_model_t model,
const bool on, const stdAc::opmode_t mode,
const bool celsius, const float degrees,
const stdAc::fanspeed_t fan,
const stdAc::swingv_t swingv,
const stdAc::swingh_t swingh,
const bool turbo, const bool quiet, const bool filter,
const int16_t sleep)

3289: haier176(&ac, (haier_ac176_remote_model_t)send.model, send.power,
send.mode, send.celsius, send.degrees, send.fanspeed,
send.swingv, send.swingh, send.turbo, send.filter, send.sleep);

The call of function haier176 dont have "const bool quiet" argument

[crankyoldgit]

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

[MarkKoshelev]

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

You have fixed ony one function (haier176). But the same bug is in a nubber of functions.
I see them in haierYrwo2 also.
Please check all functions declaration and implementation. All haierXXX function have this bug.

[NiKiZe]

@MarkKoshelev I think I've fixed it. Can you please confirm it now operates as expected in the master branch?

You have fixed ony one function (haier176). But the same bug is in a nubber of functions. I see them in haierYrwo2 also. Please check all functions declaration and implementation. All haierXXX function have this bug.

Feel free to create one or more PRs 😉

[MarkKoshelev]

Hi I use tasmota project code. It uses IRremoteESP8266 v2.8.4. After the same fixes locally is OK with haier176. Its look like correctly with the another haier AC now. From: Christian I. Nilsson ***@***.*** Sent: Wednesday, July 3, 2024 9:13 AM To: crankyoldgit/IRremoteESP8266 Cc: MarkKoshelev; Mention Subject: Re: [crankyoldgit/IRremoteESP8266] The implementation and declaration of some functions differs from the function call (Issue #2101) @MarkKoshelev <https://github.com/MarkKoshelev> I think I've fixed it. Can you please confirm it now operates as expected in the master branch? You have fixed ony one function (haier176). But the same bug is in a nubber of functions. I see them in haierYrwo2 also. Please check all functions declaration and implementation. All haierXXX function have this bug. Feel free to create one or more PRs 😉 — Reply to this email directly, view it on GitHub <#2101 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMEOQ7HHDG2WHWKII7DRUCDZKOI6PAVCNFSM6AAAAABIYZFJI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBVGE3TGNBSHE> . You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AMEOQ7A2Q5UMLZEQIEHZTPTZKOI6PA5CNFSM6AAAAABIYZFJI2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUDOBDLK.gif> Message ID: ***@***.***>