Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IRMQTTSERVER- /sent vs /send - Payload mismatch in serial monitor and MQTT #459

Closed
DiggiD opened this issue May 14, 2018 · 4 comments
Closed

IRMQTTSERVER- /sent vs /send - Payload mismatch in serial monitor and MQTT #459

DiggiD opened this issue May 14, 2018 · 4 comments
Assignees
@crankyoldgit
Labels
bug

Comments

@DiggiD
Copy link

DiggiD commented May 14, 2018 •
edited
Loading

sending HITACHI AC codes using mqtt with IRMQTTSERVER compiled to ESP8266-01
works great, AC responds to commands.

this is the result im getting in the serial monitor when i send mqtt payload to /send topic: "40,0xB2AE4D51F061840000000030B8"

0002273.587: MQTT Payload (raw): 40,0xB2AE4D51F061840000000030B8
0002273.816: Sent the IR message.
0002273.816: Type: 40
0002273.817: Code: 0x61840000000030B8
0002273.817: Bits: 0
0002273.817: Repeats: 0

using MQTT Lens subscribed to my send/sent topics i see

/send
40,0xB2AE4D51F061840000000030B8
/sent
40,61840000000030B8,0,0
@crankyoldgit crankyoldgit self-assigned this May 14, 2018
crankyoldgit added a commit that referenced this issue May 14, 2018
@crankyoldgit
BUG: Incorrect acknowledgements for some A/C protocols.
2cf1301 
Forgot to update this section of code for other A/C protocols, so using
a standard function to keep it up-to-date in future.

Fixes #459
crankyoldgit added a commit that referenced this issue May 14, 2018
@crankyoldgit
BUG: Incorrect acknowledgements for some A/C protocols.
5123b98 
Forgot to update this section of code for other A/C protocols, so using
a standard function to keep it up-to-date in future.

Fixes #459
@crankyoldgit crankyoldgit mentioned this issue May 14, 2018
Merged
@crankyoldgit
Copy link
Owner

Should be fixed in this branch: https://github.com/markszabo/IRremoteESP8266/tree/issue-459
@DiggiD Can you please test this to see if it gives the correct results in the serial output and via MQTT?

crankyoldgit added a commit that referenced this issue May 14, 2018
@crankyoldgit
BUG: Incorrect acknowledgements for some A/C protocols.
560372e 
Forgot to update this section of code for other A/C protocols, so using
a standard function to keep it up-to-date in future.

Fixes #459
@DiggiD
Copy link
Author

DiggiD commented May 14, 2018

checked!

0000443.204: MQTT Payload (raw): 40,0xB2AE4D51F061840000000030B8
0000443.433: Sent the IR message.
0000443.433: Type: 40
0000443.434: Code:
0000443.434: 0xB2AE4D51F061840000000030B8
0000443.434: Repeats: 0

/send
40,0xB2AE4D51F061840000000030B8
/sent
40,0xB2AE4D51F061840000000030B8

:) thanks!

@crankyoldgit
Copy link
Owner

Thanks for confirming. Just waiting on the code review then I'll merge it into the master branch.

crankyoldgit added a commit that referenced this issue May 14, 2018
@crankyoldgit
BUG: Incorrect acknowledgements for some A/C protocols. (#460)
7c06012 
Forgot to update this section of code for other A/C protocols, so using
a standard function to keep it up-to-date in future.

Fixes #459
@crankyoldgit
Copy link
Owner

This fix has been included in the latest release (v2.4.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DiggiD @crankyoldgit