Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI pipeline to use PlatformIO build tools #885

Closed
augustozanellato opened this issue Sep 2, 2019 · 12 comments · Fixed by #936
Closed

Update CI pipeline to use PlatformIO build tools #885

augustozanellato opened this issue Sep 2, 2019 · 12 comments · Fixed by #936
Assignees
Labels
enhancement Hacktoberfest Hacktoberfest participation

Comments

@augustozanellato
Copy link
Contributor

augustozanellato commented Sep 2, 2019

Using platformio command to build the library on TravisCI should be a lot less a mess than installing a full fledged Arduino environment every time a CI build is done

If you confirm me that you are ok with implementing this I can add it to my already open PR #884

@crankyoldgit
Copy link
Owner

Please submit it in a separate PR. Yes, I'm fine with moving to using platformio in Travis

@augustozanellato
Copy link
Contributor Author

Should I also move the testing infrastructure to PlatformIO unit testing?

@crankyoldgit
Copy link
Owner

Not yet. But we can look at it after this.

@crankyoldgit
Copy link
Owner

I saw in your repo you had made some efforts in doing this. How's it going?

@augustozanellato
Copy link
Contributor Author

augustozanellato commented Sep 10, 2019 via email

@crankyoldgit
Copy link
Owner

No worries. I was just checking in. Thanks very much for offering to do it and for what you've tried thus far.

@crankyoldgit
Copy link
Owner

How goes it? Just a reminder/incentive, your eventual PR is worth a quarter of a t-shirt if you get it in this month. See #932

@augustozanellato
Copy link
Contributor Author

I’m just full with school stuff atm, probably around the end of this week I could take an in depth look into it

@crankyoldgit
Copy link
Owner

School comes first. No rush or pressure. Just trying to make sure your effort might help score you a shirt. :)

@augustozanellato
Copy link
Contributor Author

augustozanellato commented Oct 1, 2019

The PR is almost ready, the only problem is with the Web-AC-control example as you can see here, but it seems to be a bug in the platformio file for that example

EDIT: nvm, it was an issue on my code, but there's still a little error

crankyoldgit added a commit that referenced this issue Oct 2, 2019
Hat tip to @augustozanellato for finding the issue.
Ref #885 & #936
crankyoldgit added a commit that referenced this issue Oct 2, 2019
crankyoldgit pushed a commit that referenced this issue Oct 2, 2019
@crankyoldgit
Copy link
Owner

Ref #932

@crankyoldgit crankyoldgit added the Hacktoberfest Hacktoberfest participation label Oct 2, 2019
@crankyoldgit
Copy link
Owner

FYI, the changes mention above have been included in the v2.7.0 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants