-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI pipeline to use PlatformIO build tools #885
Comments
Please submit it in a separate PR. Yes, I'm fine with moving to using platformio in Travis |
Should I also move the testing infrastructure to PlatformIO unit testing? |
Not yet. But we can look at it after this. |
I saw in your repo you had made some efforts in doing this. How's it going? |
Still working on that on my local copy
… Il giorno 10 set 2019, alle ore 03:19, David Conran ***@***.***> ha scritto:
I saw in your repo you had made some efforts in doing this. How's it going?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
No worries. I was just checking in. Thanks very much for offering to do it and for what you've tried thus far. |
How goes it? Just a reminder/incentive, your eventual PR is worth a quarter of a t-shirt if you get it in this month. See #932 |
I’m just full with school stuff atm, probably around the end of this week I could take an in depth look into it |
School comes first. No rush or pressure. Just trying to make sure your effort might help score you a shirt. :) |
The PR is almost ready, the only problem is with the Web-AC-control example as you can see here, but it seems to be a bug in the platformio file for that example EDIT: nvm, it was an issue on my code, but there's still a little error |
Hat tip to @augustozanellato for finding the issue. Ref #885 & #936
Hat tip to @augustozanellato for finding the issue. Ref #885 & #936
Ref #932 |
FYI, the changes mention above have been included in the v2.7.0 release of the library. |
Using platformio command to build the library on TravisCI should be a lot less a mess than installing a full fledged Arduino environment every time a CI build is done
If you confirm me that you are ok with implementing this I can add it to my already open PR #884
The text was updated successfully, but these errors were encountered: