Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Supported Devices scraping. #1006

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Improve Supported Devices scraping. #1006

merged 1 commit into from
Dec 17, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Fix NEC, LG, & Magiquest being dectected as supported AC protocols.
  • Stricter regex matching for filenames. FYI @sillyfrog

@crankyoldgit
Improve Supported Devices scraping.
961d60b 
* Fix NEC, LG, & Magiquest being dectected as supported AC protocols.
* Stricter regex matching for filenames. FYI @sillyfrog
@crankyoldgit crankyoldgit self-assigned this Dec 16, 2019
sillyfrog
sillyfrog approved these changes Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@sillyfrog sillyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Good catch on the regex.
Cheers.

@crankyoldgit crankyoldgit merged commit d4a3258 into master Dec 17, 2019
@crankyoldgit
Copy link
Owner Author

Thanks for the prompt code review.

@crankyoldgit crankyoldgit deleted the supported_devices branch December 29, 2019 09:13
crankyoldgit added a commit that referenced this pull request Jan 6, 2020
@crankyoldgit
v2.7.2 release
cdfe2fd 
_v2.7.2 (20200106)_

**[Bug Fixes]**
- Common AC api: Better handle protocols with power toggles. (#1002)

**[Features]**
- Experimental detailed support for LG a/c. (#1008 #1009)

**[Misc]**
- Add remote codes for Aloka LED lamp. (#1005)
- Improve Supported Devices scraping. (#1006)
@crankyoldgit crankyoldgit mentioned this pull request Jan 6, 2020
Merged
crankyoldgit added a commit that referenced this pull request Jan 6, 2020
@crankyoldgit
v2.7.2 release (#1011)
e492ff1 
_v2.7.2 (20200106)_

**[Bug Fixes]**
- Common AC api: Better handle protocols with power toggles. (#1002)

**[Features]**
- Experimental detailed support for LG a/c. (#1008 #1009)

**[Misc]**
- Add remote codes for Aloka LED lamp. (#1005)
- Improve Supported Devices scraping. (#1006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog sillyfrog approved these changes

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @sillyfrog