IRMQTTServer: Use more i18n text. #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use existing `IRtext` strings where possible to handle Internationalisation. * Use the `KEY_*` defines in the examples/forms in cause the use changes them. * Update some misc text to be better from an i18n perspective. * NOTE: No where near a complete i18n conversion. * Tested with en-AU & zh-CN. Appears to work as expected.
|
Great project, come on. Expect more new features |
|
7 days are up. |
crankyoldgit
added a commit
that referenced
this pull request
Apr 25, 2020
_v2.7.6 (20200425)_ **[Features]** - IRMQTTServer: Use more i18n text. (#1086) - Convert Protocol names to shared text. Saves ~3k of flash. (#1078) - Add Chinese translation (zh-CN) & add utf-8 support. (#1080, #1085) **[Misc]** - IRMQTTServer: Ensure MQTT_MAX_PACKET_SIZE is correctly set. (#1084) - Add Italian locale to IRrecvDumpV2 platformio file.
Merged
crankyoldgit
added a commit
that referenced
this pull request
Apr 25, 2020
_v2.7.6 (20200425)_ **[Features]** - IRMQTTServer: Use more i18n text. (#1086) - Convert Protocol names to shared text. Saves ~3k of flash. (#1078) - Add Chinese translation (zh-CN) & add utf-8 support. (#1080, #1085) **[Misc]** - IRMQTTServer: Ensure MQTT_MAX_PACKET_SIZE is correctly set. (#1084) - Add Italian locale to IRrecvDumpV2 platformio file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use existing
IRtextstrings where possible to better handle Internationalisation(i18n).Use the
KEY_*defines in the examples/forms in case the user changes them.Update some misc text to be better from an i18n perspective.
NOTE: Nowhere near a complete i18n conversion.
Bump IRMQTTServer version number.
Tested with en-AU & zh-CN. Appears to work as expected.
FYI @Caffreyfans