Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Vexation With Doxygen! #1195

Merged
merged 8 commits into from
Jun 15, 2020
Merged

Total Vexation With Doxygen! #1195

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0b08ccd
Doxify TCL
crankyoldgit Jun 15, 2020
85e5736
Doxify Teco
crankyoldgit Jun 15, 2020
d5cc711
Doxify Toshiba
crankyoldgit Jun 15, 2020
1a7fc0d
Doxify Trotec
crankyoldgit Jun 15, 2020
e7cd74c
Doxify Vestel
crankyoldgit Jun 15, 2020
0f8e91c
Doxify Whirlpool
crankyoldgit Jun 15, 2020
055213e
Doxify Whynter
crankyoldgit Jun 15, 2020
9402335
Code review feedback.
crankyoldgit Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/IRsend.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,8 +337,8 @@ class IRsend {
uint16_t repeat = kCoolixDefaultRepeat);
#endif
#if SEND_WHYNTER
void sendWhynter(uint64_t data, uint16_t nbits = kWhynterBits,
uint16_t repeat = kNoRepeat);
void sendWhynter(const uint64_t data, const uint16_t nbits = kWhynterBits,
const uint16_t repeat = kNoRepeat);
#endif
#if SEND_MITSUBISHI
void sendMitsubishi(uint64_t data, uint16_t nbits = kMitsubishiBits,
Expand Down
6 changes: 4 additions & 2 deletions src/ir_Samsung.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ uint32_t IRsend::encodeSAMSUNG(const uint8_t customer, const uint8_t command) {
/// raw data. Typically/Defaults to kStartOffset.
/// @param[in] nbits The number of data bits to expect.
/// @param[in] strict Flag indicating if we should perform strict matching.
/// @return True if it can decode it, false if it can't.
/// @note LG 32bit protocol appears near identical to the Samsung protocol.
/// They differ on their compliance criteria and how they repeat.
/// @see http://elektrolab.wz.cz/katalog/samsung_protocol.pdf
Expand Down Expand Up @@ -180,6 +181,7 @@ void IRsend::sendSamsung36(const uint64_t data, const uint16_t nbits,
/// raw data. Typically/Defaults to kStartOffset.
/// @param[in] nbits The number of data bits to expect.
/// @param[in] strict Flag indicating if we should perform strict matching.
/// @return True if it can decode it, false if it can't.
/// @see https://github.com/crankyoldgit/IRremoteESP8266/issues/621
bool IRrecv::decodeSamsung36(decode_results *results, uint16_t offset,
const uint16_t nbits, const bool strict) {
Expand Down Expand Up @@ -318,7 +320,7 @@ bool IRSamsungAc::validChecksum(const uint8_t state[], const uint16_t length) {
}

/// Update the checksum for the internal state.
/// @param[in] length The length/size of the nternal array to checksum.
/// @param[in] length The length/size of the internal array to checksum.
void IRSamsungAc::checksum(uint16_t length) {
if (length < 13) return;
setBits(&remote_state[length - 6], kHighNibble, kNibbleSize,
Expand Down Expand Up @@ -695,7 +697,6 @@ stdAc::fanspeed_t IRSamsungAc::toCommonFanSpeed(const uint8_t spd) {
}
}


/// Convert the current internal state into its stdAc::state_t equivilant.
/// @return The stdAc equivilant of the native settings.
stdAc::state_t IRSamsungAc::toCommon(void) {
Expand Down Expand Up @@ -776,6 +777,7 @@ String IRSamsungAc::toString(void) {
/// raw data. Typically/Defaults to kStartOffset.
/// @param[in] nbits The number of data bits to expect.
/// @param[in] strict Flag indicating if we should perform strict matching.
/// @return True if it can decode it, false if it can't.
/// @see https://github.com/crankyoldgit/IRremoteESP8266/issues/505
bool IRrecv::decodeSamsungAC(decode_results *results, uint16_t offset,
const uint16_t nbits, const bool strict) {
Expand Down
Loading