Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG A/C: Potential fix for A/C power off issue. #1299

Closed
wants to merge 1 commit into from
Closed

LG A/C: Potential fix for A/C power off issue. #1299

wants to merge 1 commit into from

Conversation

crankyoldgit
Copy link
Owner

LG's A/C power off sets the temp to a special value. So move the setPower() call to last in IRac::lg() so it happens after any temp changes.

Ref: #1298 (comment)
Fixes #1298

@crankyoldgit
LG A/C: Potential fix for A/C power off issue.
4d81211 
LG's A/C power off sets the temp to a special value. So move the `setPower()` call to last in `IRac::lg()` so it happens after any temp changes.

Ref: #1298 (comment)
Fixes #1298
@crankyoldgit crankyoldgit added bug Hacktoberfest Hacktoberfest participation Pending Confirmation Waiting for confirmation from user hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest. labels Oct 15, 2020
@crankyoldgit crankyoldgit requested a review from NiKiZe October 15, 2020 00:06
@crankyoldgit crankyoldgit self-assigned this Oct 15, 2020
@crankyoldgit crankyoldgit mentioned this pull request Oct 15, 2020
Closed
@crankyoldgit
Copy link
Owner Author

This fix/change is not needed as it is already accounted for elsewhere in the code.
i.e.

IRremoteESP8266/src/ir_LG.cpp

Lines 279 to 281 in ecfc472

// Always send the special Off command if the power is set to off.
// Ref: https://github.com/crankyoldgit/IRremoteESP8266/issues/1008#issuecomment-570763580
_irsend.send(this->_protocol, kLgAcOffCommand, kLgBits, repeat);

@crankyoldgit crankyoldgit deleted the Issue1298 branch October 15, 2020 07:59
@crankyoldgit crankyoldgit removed Pending Confirmation Waiting for confirmation from user bug labels Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
Hacktoberfest Hacktoberfest participation hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LG AC strange behavior
2 participants
@crankyoldgit @NiKiZe