LG2: Better enforce a repeat for LG2 messages. #1300
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Looking at comments for LG2 it seems the repeat is manditory, but we have no proof. So, lets try making it (a minimum of a single repeat for LG2) manditory in most cases. * LG should stay the same with "no repeats" as the default. * Extend existing unit tests to cover these points and to confirm expected operation. This really needs to verified with hard data to be sure. Might fix #1298
crankyoldgit
added
enhancement
Hacktoberfest
Closed
NiKiZe
approved these changes
Oct 16, 2020
|
This is looking more and more like it isn't needed. We've seen no evidence that there is a repeat required for the LG2 protocol. |
|
Abandoning in favour of #1304 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IRsend::sendLG2()it seems the repeat is mandatory, but we have no proof it is. So, lets try making it (a minimum of a single repeat for LG2) mandatory in most cases.This really needs to verified with hard data to be sure.
Might fix #1298