Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharpAc: Add model support for A705 #1313

Merged
merged 4 commits into from
Nov 9, 2020
Merged

SharpAc: Add model support for A705 #1313

merged 4 commits into from
Nov 9, 2020

Conversation

crankyoldgit
Copy link
Owner

  • Support models A907 & A705
  • Remove this-> from Sharp.
  • Update unit tests accordingly.
  • Update common A/C api.

Fixes #1309

@crankyoldgit
SharpAc: Add model support
53585ea 
* Support model `A907` & `A705`
  - A705 support only partial. Not working fully.
* Remove `this->` from Sharp.
* Update unit tests accordingly.
* Update common A/C api.

For #1309
@crankyoldgit
SharpAc: Add light toggle support for model A705
e23436a 
* A907's Economy & A705 Light seem to share the same bits.
* Handle responses according to detected model.
* Update unit tests

For #1309
@crankyoldgit
SharpAc: Handle A705 operating modes.
f5efe4d 
* A705 has no heat mode, and thinks Auto mode is Fan mode.
* Update & extend unit tests.

For #1309
@crankyoldgit
SharpAc: Report fan speeds correctly for A705 models.
a8eec56 
Fixes #1309
@crankyoldgit crankyoldgit added enhancement Hacktoberfest Hacktoberfest participation Pending Confirmation Waiting for confirmation from user hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest. labels Oct 27, 2020
@crankyoldgit crankyoldgit requested a review from NiKiZe October 27, 2020 02:11
@crankyoldgit crankyoldgit self-assigned this Oct 27, 2020
@crankyoldgit crankyoldgit mentioned this pull request Oct 27, 2020
Closed
@crankyoldgit
Copy link
Owner Author

Hmm. For what ever reason Travis CI doesn't appear to be working. i.e. It's not starting the jobs correctly.

I've run all the unit tests, linter, & doxygen checks manually. All seem fine. O_o

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Nov 9, 2020
@crankyoldgit
Copy link
Owner Author

User confirmed it is working.

@crankyoldgit crankyoldgit merged commit a74eff1 into master Nov 9, 2020
@crankyoldgit crankyoldgit deleted the Sharp_CRMC-A705JBEZ branch November 10, 2020 07:31
crankyoldgit added a commit that referenced this pull request Nov 13, 2020
@crankyoldgit
v2.7.12 release
535b7e4 
_v2.7.12 (20201113)_

**[Bug Fixes]**
- `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314)
- Fix LG2 timings and refactor `decodeLG()` (#1298 #1304)

**[Features]**
- Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327)
- SharpAc: Add model support for A705 (#1309 #1313)
- Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316)
- Add support for Elite Screens protocol. (#1306 #1310)
- IRrecvDumpV2+: Add tolerance setting. (#1292)
- Add basic support for the Mirage Protocol. (#1289 #1291)
- Internationalisation Support
  - pt-BR: Add Portuguese/Brazilian support. (#1303)
  - de-DE: Backfill missing strings (#1294)
  - de-DE: update for recent addition of 'tolerance' (#1293)
  - de-DE: Translate root README.md into German (#1297)

**[Misc]**
- refactor ir_LG (#1325)
- refactor ir_Kelvinator (#1317)
- refactor ir_Hitachi (#1308)
- refactor ir_Goodweather (#1295)
- refactor ir_Electra (#1290)
- refactor ir_Daikin (#1288)
- Update Kaysun supported models. (#1322)
- fix typos/spelling mistakes (#1301)
- Add some missing Doxygen class/data-type descriptions. (#1287)
@crankyoldgit crankyoldgit mentioned this pull request Nov 13, 2020
Merged
crankyoldgit added a commit that referenced this pull request Nov 13, 2020
@crankyoldgit
v2.7.12 release (#1330)
b7fa4ba 
_v2.7.12 (20201113)_

**[Bug Fixes]**
- `defaultBits()` returned incorrect result for `PANASONIC_AC` (#1307 #1314)
- Fix `LG2` timings and refactor `decodeLG()` (#1298 #1304)

**[Features]**
- Midea: Add support for "Follow Me"/Sensor, Turbo, Light, & Timers (#1318 #1327)
- SharpAc: Add model support for A705 (#1309 #1313)
- Add basic support for Panasonic A/C 32bit/16bit protocol. (#1307 #1316)
- Add support for Elite Screens protocol. (#1306 #1310)
- IRrecvDumpV2+: Add tolerance setting. (#1292)
- Add basic support for the Mirage Protocol. (#1289 #1291)
- Internationalisation Support
  - `pt-BR`: Add Portuguese/Brazilian support. (#1303)
  - `de-DE`: Backfill missing strings (#1294)
  - `de-DE`: update for recent addition of 'tolerance' (#1293)
  - `de-DE`: Translate root README.md into German (#1297)

**[Misc]**
- refactor ir_LG (#1325)
- refactor ir_Kelvinator (#1317)
- refactor ir_Hitachi (#1308)
- refactor ir_Goodweather (#1295)
- refactor ir_Electra (#1290)
- refactor ir_Daikin (#1288)
- Update Kaysun supported models. (#1322)
- fix typos/spelling mistakes (#1301)
- Add some missing Doxygen class/data-type descriptions. (#1287)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Hacktoberfest Hacktoberfest participation hacktoberfest-accepted Marking PRs as accepted for Hacktoberfest.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sharp CRMC-A705JBEZ Support
2 participants
@crankyoldgit @NiKiZe