Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SupportedProtocols.md with additional Panasonic AC Models #1524

Closed
wants to merge 1 commit into from
Closed

Conversation

ajaypala
Copy link
Contributor

@ajaypala ajaypala commented Jul 6, 2021

No description provided.

@crankyoldgit
Copy link
Owner

Sadly, this is not the way to add them. This file is automatically generated, so if you add them manually, they will disappear next update.
i.e. from https://github.com/crankyoldgit/IRremoteESP8266/wiki/Library-Maintainers-Guide#new-version-release-checklist

7. Run tools/scrape_supported_devices.py from the top directory. (Requires Python3)

That program scrapes entries from the code files to build the file.
e.g.

// Supports:
// Brand: Panasonic, Model: TV (PANASONIC)
// Brand: Panasonic, Model: NKE series A/C (PANASONIC_AC NKE/2)
// Brand: Panasonic, Model: DKE series A/C (PANASONIC_AC DKE/3)
// Brand: Panasonic, Model: DKW series A/C (PANASONIC_AC DKE/3)
// Brand: Panasonic, Model: PKR series A/C (PANASONIC_AC DKE/3)
// Brand: Panasonic, Model: JKE series A/C (PANASONIC_AC JKE/4)
// Brand: Panasonic, Model: CKP series A/C (PANASONIC_AC CKP/5)
// Brand: Panasonic, Model: RKR series A/C (PANASONIC_AC RKR/6)
// Brand: Panasonic, Model: CS-ME10CKPG A/C (PANASONIC_AC CKP/5)
// Brand: Panasonic, Model: CS-ME12CKPG A/C (PANASONIC_AC CKP/5)
// Brand: Panasonic, Model: CS-ME14CKPG A/C (PANASONIC_AC CKP/5)
// Brand: Panasonic, Model: CS-E7PKR A/C (PANASONIC_AC DKE/2)
// Brand: Panasonic, Model: CS-Z9RKR A/C (PANASONIC_AC RKR/6)
// Brand: Panasonic, Model: CS-YW9MKD A/C (PANASONIC_AC JKE/4)
// Brand: Panasonic, Model: A75C2311 remote (PANASONIC_AC CKP/5)
// Brand: Panasonic, Model: A75C2616-1 remote (PANASONIC_AC DKE/3)
// Brand: Panasonic, Model: A75C3704 remote (PANASONIC_AC DKE/3)
// Brand: Panasonic, Model: A75C3747 remote (PANASONIC_AC JKE/4)
// Brand: Panasonic, Model: CS-E9CKP series A/C (PANASONIC_AC32)
// Brand: Panasonic, Model: A75C2295 remote (PANASONIC_AC32)

TL;DR: You need to add them there, and they will get picked up in the next run.

Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajaypala
Copy link
Contributor Author

ajaypala commented Jul 6, 2021

Oops. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants