Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LG] Add support for AKB73757604 model #1545

Merged
merged 5 commits into from
Aug 4, 2021
Merged

[LG] Add support for AKB73757604 model #1545

merged 5 commits into from
Aug 4, 2021

Conversation

crankyoldgit
Copy link
Owner

  • Support for Vertical Swing on multiple vanes.
  • Support for Horizontal Swing.
  • Model detection.
  • Unit tests added & updated.

Fixes #1531

@crankyoldgit
[LG] Add support for AKB73757604 model
8bd0555 
* Support for Vertical Swing on multiple vanes.
* Support for Horizontal Swing.
* Model detection.
* Unit tests added & updated.

Fixes #1531
@crankyoldgit
Additional unit test data.
0705d9f
@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Aug 3, 2021
@crankyoldgit crankyoldgit self-assigned this Aug 3, 2021
NiKiZe
NiKiZe approved these changes Aug 3, 2021
View reviewed changes
src/ir_LG.cpp Outdated Show resolved Hide resolved
src/ir_LG.cpp Outdated Show resolved Hide resolved
src/ir_LG.cpp Outdated Show resolved Hide resolved
src/ir_LG.cpp Outdated Show resolved Hide resolved
src/ir_LG.cpp Outdated Show resolved Hide resolved
@crankyoldgit
Respond to codereview feedback.
528bca2 
* Use more constants and comments
* Use a macro() for some stuff to make it clearer.
@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Aug 3, 2021 •
edited
Loading

Update. @NiKiZe want to take another look to see if it satisfies your review comments?

Btw, thanks for the code review. It was good feedback!

NiKiZe
NiKiZe approved these changes Aug 3, 2021
View reviewed changes
Copy link
Collaborator

@NiKiZe NiKiZe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great as it is.

My remaining comments is just a few things that I'm not sure about that you might want to double check.

src/ir_LG.cpp Show resolved Hide resolved
src/ir_LG.cpp Show resolved Hide resolved
src/ir_LG.cpp Show resolved Hide resolved
@crankyoldgit
Fix problem with vane position decoding.
46573ca 
* Fix a dumb math fail.
* Add unit test to make sure it stays fixed.

Ref: #1531 (comment)
@crankyoldgit crankyoldgit merged commit 1c9a75b into master Aug 4, 2021
@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Aug 4, 2021
@crankyoldgit crankyoldgit deleted the AKB73757604 branch August 6, 2021 07:32
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
1fbac6c 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
@crankyoldgit crankyoldgit mentioned this pull request Aug 28, 2021
Merged
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release
e8dee1a 
_v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
crankyoldgit added a commit that referenced this pull request Aug 28, 2021
@crankyoldgit
v2.7.20 release (#1582)
21e7dd4 
## _v2.7.20 (20210828)_

**[Bug Fixes]**
- Make `strToSwingH()` match "Right Max" (#1550 #1551)

**[Features]**
- Experimental Bose remote support (#1579)
- Added MitsubishiAC VaneLeft (#1572 #1576)
- HAIER_AC176: Add experimental detailed support (#1480 #1571)
- Detailed support for Tornado/Sanyo 88-bit A/C protocol (#1503 #1568)
- Add support for new `TROTEC_3550` A/C protocol (#1563 #1566 #1507)
- SamsungAc: Use `sendExtended()` going forward. (#1484 #1562)
- SamsungAc: Redo/fix checksum calculations. (#1538 #1554)
- LG: Add support for `AKB73757604` model (#1531 #1545)
- Daikin176: Add support for Unit Id. (#1543 #1544)
- Daikin2: Add support for Humidity setting/operation. (#1535 #1540)
- TCL112AC: Add support for quiet/mute setting. (#1528 #1529)
- LG2: Add Fan speed, Swing, & Light support for new `AKB74955603` model (#1513 #1530)
- Add Mitsubishi AC "fan only" mode (#1527)

**[Misc]**
- Change when some github workflows run (#1583)
- Add/update supported device info (#1580 #1581 #1585)
- Fix pylint issues due to pylint update. (#1569 #1570)
- DAIKIN216: Update supported models. (#1552 #1567)
- IRMQTTServer: Build a minimal OTA image via PlatformIO. (#1513 #1541)
- Reduce memory fragmentation cause by String usage. (#1493 #1536)
- Refactor `decodeMitsubishiAC()` (#1523 #1532)
- Fix incorrect comment.
- Migrate from Travis to GitHub Actions (#1522 #1526)
- Documentation update with additional supported Panasonic AC models (#1525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiKiZe NiKiZe NiKiZe approved these changes

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for LG AKB73757604 remote (new model with vertical and horizontal swing)
2 participants
@crankyoldgit @NiKiZe