Cosmetic replace 'fan_only' string

[PtilopsisLeucotis]

Hi

This is cosmetic fix, that replace string 'fan_only' to 'Fan Only', for better visual consistency

[crankyoldgit]

The reason "Fan_Only" is used, instead of "Fan Only" is because Google Home + Home Assistant use that keyword.

We should add a note to this affect and possibly think of adding "Fan Only" as an addition.

[PtilopsisLeucotis]

Now in code used string in lower case ('fan_only'). If we cannot use "Fan Only" string, may be better to use "Fan_Only" string (capitalized)?

[NiKiZe]

We will probably not merge this, but instead we should just try to add documentation to fan_only to explain why it is as it is.

However let me take the opportunity to say that if we where to consider this PR then it must be without the changes to doxygen, since that is generated and merged during release process, if any changes is made directly to the files we are more likely to get unnecessary merge conflicts during the release process.

[crankyoldgit]

Now in code used string in lower case ('fan_only'). If we cannot use "Fan Only" string, may be better to use "Fan_Only" string (capitalized)?

The string gets used without depending on case.
See:

IRremoteESP8266/src/IRac.cpp

Line 3080 in 5cd13df

!strcasecmp(str, kFanOnlyStr))

E.g. fAN, FaNonLy, & fAn_OnLy etc all work if you check the surrounding code.

So, I don't think we really need this PR. The only reason "only" is included is to handle systems that use it for some bizarre reason.
We do need to add a note though. Thanks for highlighting it.

[PtilopsisLeucotis]

So, I don't think we really need this PR. The only reason "only" is included is to handle systems that use it for some bizarre reason.
We do need to add a note though. Thanks for highlighting it.

The main reason, why I proposed this PR is better visual perception of log records in web console in Tasmota.
This is how currently log record look:
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"Dry","Power":"On"...
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"fan_only","Power":"On"....
It would be more consistently and more neat with if log records look as:
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"Fan_Only","Power":"On".... or
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"Fan Only","Power":"On"....

[PtilopsisLeucotis]

However let me take the opportunity to say that if we where to consider this PR then it must be without the changes to doxygen, since that is generated and merged during release process, if any changes is made directly to the files we are more likely to get unnecessary merge conflicts during the release process.

I removed all my changes in doxygen

[crankyoldgit]

Closing as I've reworked it as PR #1610