Nicer output IRac::opmodeToString for FanOnly #1612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crankyoldgit
added a commit
that referenced
this pull request
Sep 23, 2021
Add two outputs for Fan modes. Use a nicer & more obvious human mode by default, & a special output which is expected for Home Assistant + Google Home. Replaces PR #1612
|
Marking this a duplicate of #1613 as I want this done a slightly different way. |
|
Okey, good! |
crankyoldgit
added a commit
that referenced
this pull request
Sep 23, 2021
* Add two outputs for Fan mode. Use a nicer & more obvious human mode by default, & a special output which is expected for Home Assistant + Google Home. * Unit tests * Pretty up some of the switch statements. Replaces PR #1612
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to #1610
For Fan mode return "FanOnly" instead of "fan-only", it is for more nice output to string, i.e. in Tasmota log/
Before:
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"fan-only","Power":"On"...After:
..."Vendor":"HAIER_AC_YRW02","Model":-1,"Mode":"FanOnly","Power":"On"...