Fix compilation dependency of LG on Samsung send protocol #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sendSAMSUNG()` is needed by `sendLG()`, so fix the `#ifdef`s appropriately. i.e. Compilation shouldn't break if `SEND_LG == TRUE` and `SEND_SAMSUNG == FALSE` Fixes #2010
NiKiZe
approved these changes
Jul 8, 2023
Also include the compile dependency in `IRsend.h` too. Ref: #2010 (comment)
NiKiZe
approved these changes
Jul 9, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 15, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 15, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 18, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 22, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 24, 2023
dilyanpalauzov
pushed a commit
to dilyanpalauzov/Tasmota
that referenced
this pull request
Jul 26, 2023
crankyoldgit
added a commit
that referenced
this pull request
Jul 27, 2023
_v2.8.6 (20230727)_ **[Bug Fixes]** - Ensure `IRCoolixAC::toCommon()` returns `kNoTempValue` when no sensor temp is detected. (#2015 #2012) - Fix compilation dependency of LG on Samsung send protocol (#2011 #2010) - Fix missing parameter in call to `IRac::gree()` (#2008 #2007) **[Features]** - IRac: Ensure the `sleep` parameter is used for the `FUJITSU_AC` protocol. (#1992 #1991) **[Misc]** - Allow the BlynkIRRemote.ino code to compile again. (#2016) - do not list WHIRLPOOL_AC unconditionally as supported protocol (#2003) - IRUtils:typeToString() — simplify (#2002) - Fix brand Green -> Gree (#1994) - Fix undefined `std::round` compilation error (#1989)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jul 28, 2023
## _v2.8.6 (20230727)_ **[Bug Fixes]** - Ensure `IRCoolixAC::toCommon()` returns `kNoTempValue` when no sensor temp is detected. (#2015 #2012) - Fix compilation dependency of LG on Samsung send protocol (#2011 #2010) - Fix missing parameter in call to `IRac::gree()` (#2008 #2007) **[Features]** - IRac: Ensure the `sleep` parameter is used for the `FUJITSU_AC` protocol. (#1992 #1991) **[Misc]** - Allow the BlynkIRRemote.ino code to compile again. (#2016) - do not list WHIRLPOOL_AC unconditionally as supported protocol (#2003) - IRUtils:typeToString() — simplify (#2002) - Fix brand Green -> Gree (#1994) - Fix undefined `std::round` compilation error (#1989)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendSAMSUNG()is needed bysendLG(), so fix the#ifdefs appropriately.i.e. Compilation shouldn't break if
SEND_LG == TRUEandSEND_SAMSUNG == FALSEFixes #2010