Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the end of a capture better, plus more debug code. #249

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

crankyoldgit
Copy link
Owner

  • [bug] Issue Issue decoding  #243 uncovered an odd case where a zero length end gap is encountered.
  • Add unit test to cover zero length space at the end.
  • Add more debugging code for matchAtLeast()
  • [bug] fix incorrect end of buffer calculation in decodes

- [bug] Issue #243 uncovered an odd case where a zero length end gap is encountered.
- Add unit test to cover zero length space at the end.
- Add more debugging code for matchAtLeast()
- [bug] fix incorrect end of buffer calculation in decodes
@crankyoldgit crankyoldgit self-assigned this Jun 15, 2017
Copy link
Collaborator

@markszabo markszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crankyoldgit crankyoldgit merged commit f9780d6 into master Jun 15, 2017
@crankyoldgit crankyoldgit deleted the issue-243 branch June 15, 2017 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants