-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto-calibrating to most decoders #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fit it into the decodeNEC() routine as a test. Uses pointers instead of array indexing for access.
Friendly ping for reviewers. |
markszabo
approved these changes
Jul 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlights:
i.e. various times are expressed as a multiple of a common tick/period value.
This PR improves matching of messages from sources that are slightly askew from the standard.
In short, it tries to make the timings relative to itself, rather than rely solely on fixed values with a percentage variance.
This addresses a problem discovered in #264 where an Apple TV remote was producing a NEC-like message (fixed in a different PR) but had timings that should have had the NEC decoder work, but it wasn't because the 'space' values were slightly to large. (Out of spec range).
Given the existing code matches that odd example's headers, we can use that to determine that the device is a bit out of spec, and thus adjust to match the message's skew.