Remove the use of USECPERTICKs from the library. #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store and measure everything in usecs to similify things and improve timing accuracy. Reduce excess to 50us from 100us. Adjustments to RC-MM decoding to handle small measurements better. Remove calcTick(s) as it is pretty redundant now.
crankyoldgit
force-pushed
the
remove_tick
branch
from
dce5e6c to
7a66b38
Compare
- Turns out there are some protocols out there that have >65ms gaps in their protocols, so we should support that. Make the tick factor a nice power of 2 for simplicty. Allows upto 130ms gap to be captured. - Handly converting of the capture buffer into a sendRaw() compatible array. i.e. max values are UINT16_MAX, but the usecs due to the tick factor can be much larger than can be stored. Thus use a '0' encoding to glue these records togther instead of making the array data type bigger.
crankyoldgit
force-pushed
the
remove_tick
branch
from
7a66b38 to
5f5eef1
Compare
|
Sufficient time has passed. No reviewer comments. Submitting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store and measure everything in usecs to similify things and improve timing accuracy.
Reduce excess to 50us from 100us.
Adjustments to RC-MM decoding to handle small measurements better.
Remove calcTick(s) as it is pretty redundant now.