Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ir_LG.cpp #288

Closed
wants to merge 1 commit into from
Closed

Update ir_LG.cpp #288

wants to merge 1 commit into from

Conversation

xpokor02
Copy link
Contributor

I changed constants to work with LG AC

@xpokor02
Update ir_LG.cpp
0777b22 
I changed constants to work with LG AC
crankyoldgit added a commit that referenced this pull request Jul 28, 2017
@crankyoldgit
Adjust LG timings based on observations.
be2cb85 
Values based on @xpokor02's work in PR #288.

Different PR as this include the corrections for the unit-tests
and a slight change to the bit mark value so it still decodes
other GlobalCache recorded LG signals.
@crankyoldgit crankyoldgit mentioned this pull request Jul 28, 2017
Merged
@crankyoldgit crankyoldgit self-requested a review July 28, 2017 04:36
@crankyoldgit
Copy link
Owner

This fails the unit-tests for the library. I've created PR #291 which does pretty much the same thing but also fixes the tests that needed to change.

In short, this PR shouldn't go ahead. It's been superceeded by #291

@crankyoldgit crankyoldgit self-assigned this Jul 28, 2017
crankyoldgit added a commit that referenced this pull request Jul 28, 2017
@crankyoldgit
Adjust LG timings based on observations. (#291)
2bba2d4 
Values based on @xpokor02's work in PR #288.

Different PR as this include the corrections for the unit-tests
and a slight change to the bit mark value so it still decodes
other GlobalCache recorded LG signals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crankyoldgit crankyoldgit Awaiting requested review from crankyoldgit

Assignees

@crankyoldgit crankyoldgit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xpokor02 @crankyoldgit