Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gc decode improvements #312

Merged
merged 2 commits into from
Oct 4, 2017
Merged

Gc decode improvements #312

merged 2 commits into from
Oct 4, 2017

Conversation

crankyoldgit
Copy link
Owner

  • Ignore build files created by tools/Makefile.
  • Better output of gc_decode.
  • Make gc_decode to raw dump when decoding if it fails to decode, or the "-raw" flag is set.

FYI @jorgecis as the original author.

@crankyoldgit
Add tools build files & binaries to .gitignore
e0eab49
@crankyoldgit
Allow dumping the raw code in gc_decode.
f5a100b 
- Fix up dumpRawResult formatting and results.
- Clean up gc_decode output
- Add a -raw flag to gc_decode.
- Dump raw output if gc_decode can't find a standard decoder.
@crankyoldgit crankyoldgit added enhancement Hacktoberfest Hacktoberfest participation labels Oct 4, 2017
@crankyoldgit crankyoldgit self-assigned this Oct 4, 2017
markszabo
markszabo approved these changes Oct 4, 2017
View reviewed changes
Copy link
Collaborator

@markszabo markszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crankyoldgit crankyoldgit merged commit 5535da9 into master Oct 4, 2017
@crankyoldgit crankyoldgit deleted the gc_decode branch October 8, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markszabo markszabo markszabo approved these changes

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @markszabo