Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better conversions of uint64_t's to strings. #318

Merged
merged 3 commits into from
Oct 14, 2017
Merged

Better conversions of uint64_t's to strings. #318

merged 3 commits into from
Oct 14, 2017

Conversation

crankyoldgit
Copy link
Owner

  • Add a function that returns a string for uint64_t's.
  • Unit tests coverage.
  • Make it cross platform.
  • [Bug] Update MQTT example to fix poor quality hexidecimal output.

@crankyoldgit
Better conversions of uint64's to strings.
3f01847 
- Add a function that returns a string.
- Unit tests.
- Cross platform.
@crankyoldgit
C++ std::string's break the Arduino Framework.
99b0a64 
- It seems you can't `#include <string>` in Arduino without things going to custard.
@crankyoldgit
Address minor linter issues.
2051177
@crankyoldgit crankyoldgit added bug enhancement Hacktoberfest Hacktoberfest participation labels Oct 10, 2017
@crankyoldgit crankyoldgit self-assigned this Oct 10, 2017
markszabo
markszabo approved these changes Oct 14, 2017
View reviewed changes
Copy link
Collaborator

@markszabo markszabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crankyoldgit
Copy link
Owner Author

Thanks @markszabo

@crankyoldgit crankyoldgit merged commit fb0678a into master Oct 14, 2017
@crankyoldgit crankyoldgit deleted the uint64strings branch October 14, 2017 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markszabo markszabo markszabo approved these changes

@roidayan roidayan Awaiting requested review from roidayan

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
bug enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @markszabo