Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests for Toshiba A/C based on captures from a remote. #346

Merged
merged 4 commits into from
Nov 25, 2017
Merged

Unit tests for Toshiba A/C based on captures from a remote. #346

merged 4 commits into from
Nov 25, 2017

Conversation

crankyoldgit
Copy link
Owner

Data provided by @mwildbolz

@crankyoldgit crankyoldgit self-assigned this Nov 17, 2017
@crankyoldgit
Copy link
Owner Author

crankyoldgit commented Nov 17, 2017 •
edited
Loading

@mwildbolz Any chance you could:
a) Provide a capture with the remote powering off the A/C unit. Pref in a non-heat mode.
b) Details of the A/C and remote units in question. e.g. model numbers.

Thanks in advance, and thanks for the data (from #340)

@crankyoldgit
Copy link
Owner Author

#339

@mwildbolz
Copy link

Hi there!
Attached you can find the captures powering on and off - capture.txt - captured with IRrecvDumpV2

The type of the remote is WH-TA04NE / 70302C (this is the serial, I think).
The type of the installed Toshiba split device is: RAS-B13N3KVP-E
I have different Toshiba devices installed, I'll check with all of them...

BR,
Markus

@crankyoldgit
Copy link
Owner Author

Thanks @mwildbolz. I've added the 'OFF' case to the unit tests. That really is odd behaviour IMHO, but hey, it is what it is. :-/
I've also added the model info to. Thanks for all your help and fast turnaround on requests.

@mwildbolz
Copy link

mwildbolz commented Nov 22, 2017 via email

@crankyoldgit
Update Toshiba compatiablity list.
1c7b0af 
@mwildbolz reported it works these particular models.
@crankyoldgit
Copy link
Owner Author

Thanks @mwildbolz. This PR has been updated with that info.

@crankyoldgit
Copy link
Owner Author

It's been a week since the initial review request. Friendly reviewer ping. :-)

sillyfrog
sillyfrog approved these changes Nov 25, 2017
View reviewed changes
Copy link
Collaborator

@sillyfrog sillyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass - winner! :)

@crankyoldgit crankyoldgit merged commit 089c5a6 into v2.3.0-dev Nov 25, 2017
@crankyoldgit crankyoldgit deleted the toshiba_unittests branch November 25, 2017 05:12
crankyoldgit added a commit that referenced this pull request Dec 8, 2017
@crankyoldgit
v2.3.0 release (#370)
2a427c7 
* Progress commit, working but with debug and incomplete

* Timers not working

* Working Daikin decode, updated send & timer support

* Remove  set overflow

* Dev branch for the 2.3.0 release.

* Update README information
* For v2.3
* General cleanup.
* More instructions and links.

* Add support for decoding Kelvinator A/C messages. (#332)

* Add support for decoding Kelvinator A/C messages.
* Add a decodeKelvinator() method.
* Tweak Kelvinator timings to use a large-ish common tick size.
* Unit test(s) for decodeKelvinator().
* Use a union for state to use less memory.
* Add support for Kelvinator A/C decoding to the dump example code.

* Initial support for sending Toshiba A/C messages. (#333)

* Initial support for sending Toshiba A/C messages.
* Add known-working A/C unit model info.

* Add support for all A/C units in MQTT example code.

* Update the AirCon HTML form to send all complex A/C types.

* Correct missing Fujitsu A/C functionality.

* Cleanups and move header1 to flash

* Don't include Arduion.h in tests

* Use new State data when decoding

* Initial support for sending Toshiba A/C messages. (#333)

* Initial support for sending Toshiba A/C messages.
* Add known-working A/C unit model info.

* Progress commit, working but with debug and incomplete

* Timers not working

* Working Daikin decode, updated send & timer support

* Cleanups and move header1 to flash

* Don't include Arduion.h in tests

* Clean up a bunch of cpplint.py issues.

* More linter/style issues fixed.

* Fix a number of compiler warnings and allow unit tests to compile.
- Unit tests don't pass yet.

* Minor enhancements and working example

* Move a bunch of #define's to the header file.
Fix a few linter/style issues as reported by cpplint.py

* Rework checkheader() & readbits(). Add unit tests for decoding.
* Refactor checkheader() & readbits() to use a pointer for offset.
  This cleans up the code quite a lot & makes it more readable IMHO.
* Add some unit tests for decodeDaikin() using real and synthetic data.
  This allowed the refactoring above to happen without causing issues.
  Note: Not all (old) unit tests are passing at this point.
* Clean up some #define usage to make it more presentable and useful.
* General code clean up (lint and style etc)

* Fix setting econo, quiet, & powerful modes.

Unit tests were failing because econo, quiet, & powerful modes were
not mutually exclusive. Previous code did this.
The manual confirms this is correct. i.e. setting one of these modes cancels
the other conflicting modes.

The relevant unit tests now pass again.

* Update unit tests for getFan() & setFan().
- Update test cases to reflect new usage etc.
- Minor code cleanup.

* Powerful & Quiet, and Powerful & Econo are incompatible. Not Quiet & Econo.
@sillyfrog correctly pointed out Econo mode & Quiet mode are not mutually
exclusive.
Created unit tests for those cases, as well as created unit tests for
Econo mode.

* Update old unit test output to new daikin message protocol.
* Replace old formatted unit test data with data based on current sendDaikin()
* The unit test routines need more capacity to handle larger outputs.
  e.g. sendDaikin() with repeats has more than 1000 entries. Bumped to 10k.

* Fix Time/Timer methods.
* Assigning 16bit values on to a char array caused issues on some architectures.
* Cleaned up time(r) methods and correctly cleared/masked bits.
* Unit Tests added for the time/timer related methods.
* Turned off the DAIKIN_DEBUG flag.
* Minor code quality cleanups.

* Zero entire state on reset.
- We were missing zero'ing of daikin[3].

* Add unit test coverage for Sensor, Mold, & Eye modes.

* Set TIMEOUT to something more appropriate for A/C decoding.
This reverts/alters an earlier change.

* Initial support for decoding Toshiba A/C remote messages. (#340)

* Initial support for decoding Toshiba A/C remote messages. For #339
* Update Toshiba timings based on user feedback.
* Toshiba A/C always has at least one repeat according to @mwildbolz

* Add outputing the state to a human readable format.

* Typo: Fix an indent issue.

* Update Daikin to similar spec as Toshiba A/C. (#349)

* Add toString() & validChecksum() methods.
* Refactor the code for calculating state checksums.
* Add checksum verification in decodeDaikin()
* Unit test coverage for all of the above plus setRaw().
* Change the debug code to be platform neutral and use toString().
* Fix a typo.
* Make the example code more verbose.

* Update tools. (#343)

* Update tools.
* Add RawToGlobalCache.sh bash script to convert rawData into Global Cache
* Update gc_decode to handle air conditioners.
* Fix a typo

* Allow changing of the threshold of reported UNKNOWN messages. (#347)

* Value is now easily set at compile-time and/or run-time.
* Allow decodeHash() a.k.a. UNKNOWN message decoding to be completely removed.

Ref: Issue #341

* Unit tests for Toshiba A/C based on captures from a remote. (#346)

* Unit tests for Toshiba based on captures from a remote.
Data provided by @mwildbolz

* Update unit test for a 'real' power off example.

* Update working status and known-working models etc.

* Update Toshiba compatiablity list.
@mwildbolz reported it works these particular models.

* Update Kelvinator to similar spec as Toshiba A/C. (#348)

* Add setRaw(), toString(), & validChecksum() methods.
* Refactor the code for calculating state checksums.
* Add checksum verification in decodeKelvinator()
* Unit test coverage for all of the above.

* BugFix: Formatting error when rawData values > UINT16_MAX. (#355)

* Add new AutoAnalyseRawData tool (#345)

* New AutoAnalyseRawData tool
A bash script that attempts to automatically analyse raw data to
find key values and details needed to aid writing appropriate
sendXYZ() and decodeXYZ() routines.

Very ALPHA code, only supports common space encoded message formats.

* Improve AutoAnalyseRawData.sh
* Provide more detail output and values in hex/dec/bin and MSB/LSB order
* Remove some unused code.
* Use 'bc' to do the base conversion, rather than my hacky attempt.

* Add generation of suggested code to AutoAnalyseRawData

* More improvements to AutoAnalyseRawData

* Warn on > 64bit values
* Duplicate/repeate detection.
* Handle protocols without HDRs. e.g. Sharp.

* Initial check-in of Midea A/C support. (#359)

* Initial check-in of Midea A/C support.
Per Issue #354

* Midea protocol improvements.
* Add IRMideaAC class to enable message construction for Midea A/C
* Support basic settings (power, fan, standard temp, mode, sleep)
* Unit tests for the class.
* Add checksum verification to decode.
* Update real example to a cleaner one. Re-tune tolerance lower.

* Update Sharp compatablity list based on feedback. (#357)

* bugfix: Panasonic-based protocols have incorrect message gap. (#358)

See issue #356 for more details.
We were short by approx. 33.7mSecs.

* Update release notes for next (2.3.0) release.

* [PR] Magiquest Wands (#365)

Send and decode support for MagiQuest wands.

* Upgrade IRrecvDumpV2 to v0.3 (#363)

* Simplify & improve IRrecvDumpV2 example code.
* Bump version to v0.3
* Display human-readable out of compatible A/C messages.
* Move display code to IRutils.cpp
* Add unit tests for parts moved to IRutils.
* Fix a number of minor display issues.
* Layout of code in dumpV2 improved.
* Set the UNKNOWN minimum threashold to 12 to reduce noise.
* General housekeeping
* Tidy up the parameter section and add more comments/help text.

* [Bug] Fix an underlying off-by-one error in unit test helper code.
  This lead to correcting some off-by-one errors in other protocols.

* Ensure IRsendTest::reset() does a better job of reseting. (#368)

The unit test `reset()` function could allow data from previous
unit tests to leak through. So, don't use a short-cut, do a full
zero of the arrays.
This also exposed situations where a `decode()` would still work after
a `reset()`, hence a need to re-order some of the unit tests as
`IRsendTest::outputStr()` does an `implicit reset()`.

* Tweak Midea A/C timings based on user feedback. (#369)

@bwze advised different timings in #354 (comment)
Using the same final result as suggested, but with a smaller common factor for the tick to aid the automatic timing corrections.
Ref #354

* Improve Fujitsu A/C support (#367)

* Improve Fujitsu A/C support
* Fujitsu AR-DB1 support.
* add decodeFujitsuAC().
* Improve code quality.
* More unit tests.
* Add a lot of the 2.3.0 features for A/Cs to Fujitsu.
* Update IRMQTTServer.ino to support the new state sizes.
* Update IRrecvDumpV2.ino for Fujitsu A/C decoding.
* Update IRutils.ino for Fujitsu decoding.
* Add appropriate #ifdef's for A/C decoding to example code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog sillyfrog approved these changes

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crankyoldgit @mwildbolz @sillyfrog