Initial support of a "Lasertag" toy protocol #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
crankyoldgit
commented
Dec 12, 2017
crankyoldgit
commented
- sendLasertag() & decodeLasertag() for issue RC5 mod signal not working properly #366
- Add an option of a fixed 'delta' to the core matching functions.
- Tweak getRClevel() to allow custom tolerances, excess levels, and fixed ranges.
- Unit tests for Lasertag etc.
- Update example code & tools for this protocol.
* sendLasertag() & decodeLasertag() for issue #366 * Tweak getRClevel() to allow custom tolerances and excess levels. * Unit tests for Lasertag etc. * Update example code & tools for this protocol.
* Add an option of a fixed 'delta' to the matching functions. * Tune decodeLaserTag() to use a fixed range matching instead of excess and percentage tolerances. * Add more unit test cases from #366 * Add LASERTAG to known encodings.
Reported issue decoding Red units 1 & 2 data from Arduino-IRremote/Arduino-IRremote#532 (comment)
Return end of capture detection check to be the old '>='.
|
Thanks for the review @darshkpatel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.