Rework matchData() to handle equal total data bit time protocols. #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Give up on specific cpu-time optimised for matching data to save on overall code space/usage. * Improves readablity & simplicty of the function. * Now supports two more protocol types. More generic now. e.g. equal total data bit time, and arbitary mark/space timing for bit values. * Unit tests to cover those cases & supported protocol types. Ref #406
darshkpatel
approved these changes
Feb 2, 2018
|
@darshkpatel Thanks for the prompt review. FYI, it is tested/covered by the new unit tests here: https://github.com/markszabo/IRremoteESP8266/blob/master/test/IRrecv_test.cpp#L451 Plus all the existing tests for other protocols (which use |
crankyoldgit
added a commit
that referenced
this pull request
Mar 2, 2018
**[Bug Fixes]** - Ensure the IR LED is off before we start. (#405) **[Features]** - Experimental decode support for Gree HVAC units (#397) - Initial support for Haier A/Cs. (#409) - Improve timing accuracy of unit tests. (#403) - Rework matchData() to handle equal total data bit time protocols. (#408) **[Misc]** - Add startup text to IRrecvDumpV2 and IRrecvDemo (#412) - Tweak timings on Fujitsu A/C header (#418) - AutoAnalyseRawData.sh: Add some support for handling larger than 64 bit codes. (#419) - Use better comments for send GPIO in examples. (#425)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Mar 2, 2018
**[Bug Fixes]** - Ensure the IR LED is off before we start. (#405) **[Features]** - Experimental decode support for Gree HVAC units (#397) - Initial support for Haier A/Cs. (#409) - Improve timing accuracy of unit tests. (#403) - Rework matchData() to handle equal total data bit time protocols. (#408) **[Misc]** - Add startup text to IRrecvDumpV2 and IRrecvDemo (#412) - Tweak timings on Fujitsu A/C header (#418) - AutoAnalyseRawData.sh: Add some support for handling larger than 64 bit codes. (#419) - Use better comments for send GPIO in examples. (#425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code space/usage.
e.g. equal total data bit time, and arbitary mark/space timing for bit values.
Ref #406