Mitsubishi projector protocol support #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crankyoldgit
force-pushed
the
mitsubishi_projector
branch
from
0093a7b to
46cdebf
Compare
* Add model info * Minor comment and code style improvements
|
FYI, 33kHz has been confirm by @hamen |
markszabo
approved these changes
Apr 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Issue #441
Implement send & decode for Mitsubishi Projector IR remote.
This has not been tested in the real world. Only simulated testing has been performed.
i.e. No idea if the frequency modulation of 33kHz is correct. Assuming this value based on feedback that 36, 38, & 40 kHz don't work per #441 and the pre-existing
sendMitsubish()uses 33kHz.MITSUBISHI2 protocol number used for this as it is significantly different from the existing MITSUBISHI protocol.
FYI @hamen Can you see if this works for you, and also let us know the various model numbers of the devices involved.