Samsung A/C fixes & improvements #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support 21-byte Samsung A/C Messages. e.g. Special on/off messages. * Unit tests to support and verify new message types. * Tune the test/Makefile * Correct a few minor issues/style elements. Note: Checksums for extended messages don't seem to work all the time. Ref: #505
This should handle situations when the extended/long(er) on/off messages are to be sent from inside the IRSamsungAc class. Ref: #505 (comment)
* Added unit tests to decode and build states from recorded examples. TODO(Hollako): Explain why sometimes the LSB of remote_state[9] is a 1. e.g. 0xAE or 0XAF for swing move. This seems to be the only thing I can't reconstruct to be the same from all of the data provided thus far. Ref #505
…oteESP8266 into samsung-ac-fixes
markszabo
approved these changes
Oct 1, 2018
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Experimental support for Panasonic A/C messages. (#535) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Oct 2, 2018
**[Bug Fixes]** - Correct the byte used for Samsung AC Swing. (#529) - Fix not sending Samsung A/C messages in IRMQTTServer. (#529) **[Features]** - Experimental support for Electra A/C messages. (#528) - Experimental support for Panasonic A/C messages. (#535) - Samsung A/C fixes & improvements (#529) - IRMQTTServer v0.6.0 (#530) **[Misc]** - Change required WifiManager lib version to v0.14 - Add alias for RAWTICK to kRawTick. (#535) - Update sendLutron() status. (#515) - Remove leftover debug message in IRrecvDumpV2 (#526)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: The new data highlights an issue that the lowest bit in state[9]
changes without explaination. @Hollako requested to find out why.
Still Alpha code.
Ref: Issue #505