Coolix: Fix setPower(false) issue. #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sillyfrog
approved these changes
Nov 5, 2019
You're not wrong. I scratched my head for a while trying to grok it before I mapped out all the possible states and simplified (ha) it. |
|
Oh, and thanks for the very prompt and valuable code review! |
crankyoldgit
added a commit
that referenced
this pull request
Nov 25, 2019
_v2.7.1 (20191125)_ **[Bug Fixes]** - Hitachi424Ac: Fix Incorrect Power Byte Values (#987) - Coolix: Fix setPower(false) issue. (#990) **[Features]** - Use `char*` instead of `String` for common text. Saves ~1-3k. (#992, #989) - Hitachi424Ac: Add Vertical Swing ability (#986) **[Misc]** - IRMQTTServer: Update HA example/discovery message. (#995) - Move newly added common text to a better location. (#993)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Nov 25, 2019
_v2.7.1 (20191125)_ **[Bug Fixes]** - Hitachi424Ac: Fix Incorrect Power Byte Values (#987) - Coolix: Fix setPower(false) issue. (#990) **[Features]** - Use `char*` instead of `String` for common text. Saves ~1-3k. (#992, #989) - Hitachi424Ac: Add Vertical Swing ability (#986) **[Misc]** - IRMQTTServer: Update HA example/discovery message. (#995) - Move newly added common text to a better location. (#993)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #985