Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render corrections in non-ASCII code correctly #165

Closed
epage opened this issue Nov 11, 2020 · 0 comments · Fixed by #178
Closed

Render corrections in non-ASCII code correctly #165

epage opened this issue Nov 11, 2020 · 0 comments · Fixed by #178
Labels
bug Not as expected

Comments

@epage
Copy link
Collaborator

epage commented Nov 11, 2020

  • We list the byte offset and not the column
  • We point to the byte offset, and not the column, in the line
@epage epage added the bug Not as expected label Nov 11, 2020
epage pushed a commit to epage/typos that referenced this issue Nov 25, 2020
fix(report): Rendering issues with errors
d96de58 
- We aren't consistent in quoting words
- We used byte offsets rather than column counts
- We mixed styles between disallowed and corrections

Fixes crate-ci#165
@epage epage mentioned this issue Nov 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Not as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(report): Rendering issues with errors epage/typos
1 participant
@epage