Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate line number / line offset on-demand? #168

Closed
epage opened this issue Nov 12, 2020 · 0 comments · Fixed by #194
Closed

Calculate line number / line offset on-demand? #168

epage opened this issue Nov 12, 2020 · 0 comments · Fixed by #194

Comments

@epage
Copy link
Collaborator

epage commented Nov 12, 2020

Right now we proactively parse out lines and then parse within a line. What if instead we found out our line number by counting the new lines afterwards? This puts the cost on the typo case, which should be rare, rather than on every case when parsing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant