fix(fix): Update as we go #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 15 commits
January 2, 2021 12:58
epage
force-pushed
the
arch2
branch
2 times, most recently
from
1ae74a3 to
be7a81d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old architecture was limiting us. "The structure of this code looks similar, let's codify it to reduce duplication". The problem is this didn't give the Checker's enough control over the process. In adding Diffing and Fixing, I ended up using Report decorators to shoehorn things in. The problem was knowing when a file is done. Should we report additional messages? How do we handle alternate encodings?
I stepped back and decided that this was false code sharing. I bumped up the abstraction to a higher level and give the Checkers full control. There are patterns in the structure but consolidating them doesn't seem worth it.
Fixes #166
Fixes #168 (came out of new code structure)