fix: encoding issue for csv export

crawlab-team · Jul 26, 2023 · ec34918 · ec34918
1 parent f271a2f
commit ec34918
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/controllers/export.go b/controllers/export.go
@@ -8,7 +8,6 @@ import (
 	"github.com/crawlab-team/crawlab-core/interfaces"
 	"github.com/gin-gonic/gin"
 	"net/http"
-	"strconv"
 )
 
 var ExportController ActionController
@@ -117,7 +116,6 @@ func (ctx *exportContext) getExportDownload(c *gin.Context) {
 		return
 	}
 	c.Header("Content-Disposition", fmt.Sprintf("attachment; filename=%s", exp.GetDownloadPath()))
-	c.Header("Content-Length", strconv.Itoa(len(exp.GetDownloadPath())))
 	c.File(exp.GetDownloadPath())
 }
 

diff --git a/export/csv_service.go b/export/csv_service.go
@@ -119,6 +119,14 @@ func (svc *CsvService) export(export *entity.Export) {
 		return
 	}
 
+	// write bom
+	bom := []byte{0xEF, 0xBB, 0xBF}
+	_, err = csvFile.Write(bom)
+	if err != nil {
+		trace.PrintError(err)
+		return
+	}
+
 	// write csv header row
 	columns, err := svc.getColumns(query, export)
 	err = csvWriter.Write(columns)