fix: missing name and max runners when registering nodes

crawlab-team · Jul 3, 2024 · 40f37e8 · 40f37e8
1 parent 5fbcbe0
commit 40f37e8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/core/grpc/server/node_server_v2.go b/core/grpc/server/node_server_v2.go
@@ -58,11 +58,13 @@ func (svr NodeServerV2) Register(ctx context.Context, req *grpc.NodeServiceRegis
 	} else if errors2.Is(err, mongo.ErrNoDocuments) {
 		// register new
 		node = &models.NodeV2{
-			Key:      req.Key,
-			Status:   constants.NodeStatusRegistered,
-			Active:   true,
-			ActiveAt: time.Now(),
-			Enabled:  true,
+			Key:        req.Key,
+			Name:       req.Name,
+			Status:     constants.NodeStatusRegistered,
+			Active:     true,
+			ActiveAt:   time.Now(),
+			Enabled:    true,
+			MaxRunners: int(req.MaxRunners),
 		}
 		node.SetCreated(primitive.NilObjectID)
 		node.SetUpdated(primitive.NilObjectID)

diff --git a/core/node/config/config_service.go b/core/node/config/config_service.go
@@ -119,9 +119,6 @@ var _service interfaces.NodeConfigService
 var _serviceOnce = new(sync.Once)
 
 func GetNodeConfigService() interfaces.NodeConfigService {
-	if _service != nil {
-		return _service
-	}
 	_serviceOnce.Do(func() {
 		var err error
 		_service, err = newNodeConfigService()