-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for multiple PHP services #195
base: master
Are you sure you want to change the base?
Conversation
Thanks! I'll check it latter in the week. |
@cretueusebiu any news on this eagerly awaited PR? |
@cretueusebiu Any update on this PR? |
I really awaiting this massy update which will allow me to run multiple php version for each project. |
@muath-ye It's been a while since I've worked on Valet... For me it worked great so far so that's why I didn't make any updates. Also these kind of changes require a bit of manual testing both on win 8 and 10. I'll try to take a look this weekend at both the PR and the official Valet. 🤞 |
It becomes quite urgent for me to have different versions of PHP for each project. @iamroi What would be the best way to use your PR as a replacement? |
Hi @damsfx you can tell composer to use the forked repository. This might help - https://stackoverflow.com/questions/13498519/how-to-require-a-fork-with-composer Please note that I still need to do thorough testing to make sure everything works as expected. @cretueusebiu I'm hoping to add some tests this weekend. |
Hey @damsfx Please beware of the below Currently, if you miss the double quotes from this command or any other similar command for eg. |
Yes, I found the solution some time ago: {
"require": {
...
"cretueusebiu/valet-windows": "dev-master"
},
"repositories": [
{
"type": "git",
"url": "[email protected]:iamroi/valet-windows.git"
}
]
} I have made some tests ... and suggested you a PR to add PHP version in links table letting us know which version each site is running. Too busy at the moment to resume testing, but I will try. |
*/ | ||
$app->command('php:add [path]', function ($path) { | ||
info("Adding {$path}..."); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamroi TODO check if the $path is valid before proceeding
Hi @cretueusebiu , any update on this feature? |
@cretueusebiu Bump ! |
this feature held me back to switch from laragon |
Hi there! I've install the valet version 2.5, and try to use the command |
@cretueusebiu any possible ETA to have this PR merged, this feature is eagerly required by majority dev's |
Hi @damsfx . Can you tell me where you've added this please? Is it per project basis (in project's composer.json), or in the global installation of cretueusebiu/valet-windows composer.json? @cretueusebiu This is a very much needed requirement for developers. This pr has the backing of a multitude of people and should be merged asap. I love the valet windows port but it is muchly lacking in this php version switch mechanic. |
@yCodeTech you need to update the global composer file, usually located at C:\Users(your user)\AppData\Roaming\Composer and then simply run |
Hey! Amazing work on the package <3
Currently it's missing the multiple PHP versions management and the
valet use
command is disabled.This PR adds below new commands and enables
valet use
to switch between PHP versions.Examples:
valet php:add "c:\php-7.3.29"
valet php:remove "c:\php-8.1.2"
valet use 8.0.15
Also added a feature to enable an individual site to use a specific PHP version similar to this original Valet package PR laravel#1192
Example:
valet use "8.1.2" --site="foo"