Update SQL.js to fix head operations for pg engine. #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres requires the "length" function vs "len" function as some SQL engines us, this patch would add the correct wrapping in the getBlobSizefn
|
Actually "lenght(V)" is a default value for getBlobSizefn. It's only altered for MSSQL. Are you getting any error message referering to using "len"? Line 45 in b89b35f |
|
Sorry i tried len, that was my bad, the fix was enclosing the V in quotes.
…On Tue, Apr 30, 2024, 7:47 PM mikeTWC1984 ***@***.***> wrote:
Actually "lenght(V)" is a default value for getBlobSizefn. It's only
altered for MSSQL. Are you getting any error message referering to using
"len"?
https://github.com/cronicle-edge/cronicle-edge/blob/b89b35f7d2cedb9f211cbe5878002b1c5ee7dca1/engines/SQL.js#L45
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQQDAC6NE4K547VIWYSOY3ZAA3SPAVCNFSM6AAAAABHA2Q4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXG44DCNBYGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
OK. good catch. Just one more thing - any reason you use escaped " ? Why no just put statement in single quotes like: |
|
Because then I know its escaped ;) no real preference just a style thing.
…On Tue, Apr 30, 2024, 10:02 PM mikeTWC1984 ***@***.***> wrote:
OK. good catch. Just one more thing - any reason you use escaped " ? Why
no just put statement in single quotes like:
this.getBlobSizefn = 'length("V")'
—
Reply to this email directly, view it on GitHub
<#110 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACQQDAGYQRY3F5P4QP5MALLZABLNVAVCNFSM6AAAAABHA2Q4ICVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBXHEYDKOBQGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
OK. I guess update your comment (since it's casing issue, not function), I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres requires the "length" function vs "len" function as some SQL engines us, this patch would add the correct wrapping in the getBlobSizefn