Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zig.image precedence #1494

Merged
merged 1 commit into from
May 14, 2024

Conversation

thirteenowls
Copy link
Contributor

Currently, image always takes precedence over zig.image.
This change makes it so image doesn't get used when zig is enabled, even if zig.image is unset (and vice versa).

This is a breaking change.

Currently, `image` always takes precedence over `zig.image`.
This change makes it so `image` doesn't get used when zig is enabled,
even if `zig.image` is unset (and vice versa).

This is a breaking change.
@thirteenowls thirteenowls requested a review from a team as a code owner May 14, 2024 17:41
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Emilgardis Emilgardis added this pull request to the merge queue May 14, 2024
Merged via the queue into cross-rs:main with commit 7d75864 May 14, 2024
21 checks passed
@thirteenowls thirteenowls deleted the fix-zig-image-precedence branch May 14, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants