Build binary crate in CI test with nightly as well as stable #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Promisingly, ci is failing on aarch64-unknown-linux-musl as expected per #598 ... |
|
Im not sure this is something we want, but it seems sane enough. |
|
It seems arbitrary to only test nightly in that specific spot. Generally I see testing nightly as only making our CI more error prone without having an easy way to fix it when it happens. When something breaks on nightly, it will either need to be fixed upstream in Rust or in the Docker image by someone who is using that target and can actually debug the problem effectively. |
Alexhuszagh
added
S-waiting-on-team
|
I don't see much value in adding it. @reitermarkus made raised very good concerns about it and I agree fully with him. For me, this could be closed. |
|
Also in agreement with closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this isn't a completely silly idea :) but I wonder if (in connection with #598) building with nightly as part of CI makes sense? This PR makes an extremely small change to
test.shwhich should (?) build the binaryhellocrate both with stable and nightly toolchains.