-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
freebsd: Include libdevstat in build image #620
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to cross-rs#613 include libdevstat seems to be required now too. Probably due to rust-lang/libc@ac6e16b Signed-off-by: Jesse Szwedko <[email protected]>
Emilgardis
approved these changes
Dec 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, ci is blocked rn, need #609, r+ afterwards
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <[email protected]>
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <[email protected]>
pitkley
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609
bors bot
added a commit
to pitkley/in-container
that referenced
this pull request
Jan 29, 2022
32: fix: temporarily disable building and testing on FreeBSD r=pitkley a=pitkley CI is currently failing due to [1] and [2], and they are not getting merged upstream due to [3] being required first. We have to reenable this once this is resolved. [1]: cross-rs/cross#613 [2]: cross-rs/cross#620 [3]: cross-rs/cross#609 Co-authored-by: Pit Kleyersburg <[email protected]>
svenstaro
added a commit
to svenstaro/cross
that referenced
this pull request
Feb 6, 2022
Contains fixes from cross-rs#613 and cross-rs#620
svenstaro
added a commit
to svenstaro/miniserve
that referenced
this pull request
Feb 6, 2022
We're currently waiting on cross-rs/cross#613 and cross-rs/cross#620 to be merged and released for cross. Until then, we're fixing this ourselves downstream with a custom FreeBSD image.
svenstaro
added a commit
to svenstaro/miniserve
that referenced
this pull request
Feb 6, 2022
We're currently waiting on cross-rs/cross#613 and cross-rs/cross#620 to be merged and released for cross. Until then, we're fixing this ourselves downstream with a custom FreeBSD image.
9 tasks
included in #609 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #613 include libdevstat seems to be required by the libc crate now too. Probably due to rust-lang/libc@ac6e16b