This repository has been archived by the owner on Nov 5, 2018. It is now read-only.
Rename Handle to LocalHandle and remove Clone impl #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeehoonkang
approved these changes
Sep 8, 2018
Vtec234
approved these changes
Sep 9, 2018
ghost
merged commit
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handleis renamed toLocalHandleto more clearly indicate that it's a thread-local value (definitely notSync).Furthermore, the
Cloneimpl is removed because it's not very useful and it's not obvious what it does. Assuming that it registers another handle is misleading and dangerous.Finally,
default_handleis removed because it cannot be cloned anymore, but it's not very useful function anyway. We might want to later add something likewith_default_handle, but I don't see a pressing need at the moment.Closes #71.
cc @joshlf