-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build failure on nightly and the minimum version #428
Conversation
Thanks! bors r+ |
428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Co-authored-by: Taiki Endo <[email protected]>
Build failed |
@jeehoonkang Since the build on Rust 1.26 is broken, I think we need to merge this and #429 at the same time. |
Thanks for updating the dependency. bors r+ |
428: Fix breakage with nightly feature r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <[email protected]>
CI fails with permission error: https://travis-ci.org/crossbeam-rs/crossbeam/jobs/598198019#L203 |
Thinking again, downgrading only for CI looks suspicious. Then CI can only tell a modified Crossbeam (with different dependency) compiles for Rust 1.26, but not Crossbeam as-is. I think it may not be what we want... Do you know how Rayon deals with such a situation? |
Build failed |
I think the following comments accurately explain the current situation (using an old
Also, they recently bumped the minimum version to 1.28 (rayon-rs/rayon#675), so I think we can drop 1.26 and 1.27's support. Edit: see rayon-rs/rfcs#3 for rayon's a minimum Rust policy |
a897f73
to
ee23853
Compare
@jeehoonkang CI passed. |
Let's drop support for 1.26 and 1.27. |
Added commit to drop support for 1.26 and 1.27. Also, since the minimum version is 1.28, we can revert #393 and fix |
Oh...
I will use |
Thanks! bors retry |
428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <[email protected]>
Build failed |
bors retry |
428: Fix build failure on nightly and the minimum version r=jeehoonkang a=taiki-e `target_has_atomic = "cas"` was removed in rust-lang/rust#65214. Fixes rust-lang/rust#65424 Fixes #412 Co-authored-by: Taiki Endo <[email protected]>
Build succeeded |
target_has_atomic = "cas"
was removed in rust-lang/rust#65214.Fixes rust-lang/rust#65424
Fixes #412