-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a copy of the conns.AWSClient with schema.Provider.Configure #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Generate SSA topological markers for maps and scalar lists. - Cache the creation instance state even in case of errors. Signed-off-by: Alper Rifat Ulucinar <[email protected]>
/test-examples="examples/ec2/vpc.yaml" |
ulucinar
force-pushed
the
fix-1010
branch
2 times, most recently
from
December 15, 2023 13:43
33fa2b1
to
f190d5d
Compare
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
/test-examples="examples/ec2/vpc.yaml" |
ulucinar
changed the title
Use a copy of the Terraform provider schema with schema.Provider.Configure
Use a copy of the conns.AWSClient with schema.Provider.Configure
Dec 15, 2023
erhancagirici
approved these changes
Dec 15, 2023
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
/test-examples="examples/ec2/vpc.yaml" |
Backport failed for Please cherry-pick the changes locally. git fetch origin release-0.46
git worktree add -d .worktree/backport-1024-to-release-0.46 origin/release-0.46
cd .worktree/backport-1024-to-release-0.46
git checkout -b backport-1024-to-release-0.46
ancref=$(git merge-base 2849b795bdbb26de6d4d8d5b8bcde39e4a268e93 4f260ee515b26ff3ae5425c80744b811418af453)
git cherry-pick -x $ancref..4f260ee515b26ff3ae5425c80744b811418af453 |
ulucinar
added a commit
that referenced
this pull request
Dec 18, 2023
[release-0.46] Backport #1024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1010
Fixes #1018
Depends on: crossplane/upjet#313
This PR bumps the upjet dependency to commit
b674f3dd0c9f
to cache the creation instance state even in case of errors. Please see crossplane/upjet#313 for more context. It also uses a copy of the Terraform provider schema with theschema.Provider.Configure
call to prevent a race between the reconciliations of MRs belonging to different regions.It also introduces the SSA merge strategy kubebuilder markers (and the associated OpenAPI extensions) for maps and scalar lists.
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Tested manually using a custom build of the provider based on this PR: