ignore drift in rds.Cluster and rds.Instance due to engine_version diff arising out of automanaged upgrades #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravilr
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
…ff arising out of automanaged upgrades Signed-off-by: ravilr <[email protected]>
ravilr
force-pushed
the
rds_prevent_drift_due_to_automanaged_upgrades
branch
from
cafd8e7 to
c3547fb
Compare
|
/test-examples="examples/rds/v1beta1/instance.yaml" |
|
/test-examples="examples/rds/v1beta1/cluster.yaml" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #1504
RDS DB
ClusterandInstanceresources configured withautoMinorVersionUpgrade: truewill have RDS managed service upgrade the DB cluster/instances automatically to new available minor/patch versions during the configured preferred maintenance window. the provider-upjet-aws-rds controller currently, detects this auto version upgrade as a drift from the desired spec (if the spec.forProvider.engineVersion is specified in the resource spec) and ends up doing an endless diff and update cycle, resulting in exhaustion of the RDS API calls quota. AWS RDS doesn't allow engine version downgrades. So the update calls keep getting returned with error.This change customizes the terraform InstanceDiff for
ClusterandInstancerds resources to account for the above automanaged upgrades by ignoring the engine version diff, if the desired spec version is lower than the external's actual version.I have:
make reviewableto ensure this PR is ready for review.[ ] Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Cluster.rds.aws.upbound.iomanaged resource withspec.forProvider.engine_version: 8.0.mysql_aurora.3.06.1withautoMinorVersionUpgrade: true8.0.mysql_aurora.3.07.1. the database cluster engine version gets updated successfully.synced: True, without any previous endless drift->update cycle behavior.Credits: this is reusing the engine version util code from crossplane-contrib/provider-aws#1765