Bump Upjet to commit be5e036 #1573
Conversation
mergenci
requested review from
ulucinar,
sergenyalcin,
turkenf and
mbbush
as code owners
mergenci
force-pushed
the
bump-upjet-be5e036
branch
from
1da9793 to
3952f07
Compare
|
/test-examples="examples/ec2/v1beta1/vpcendpoint.yaml" This example doesn't exist yet 😒 |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
|
/test-examples="examples/dynamodb/v1beta1/table.yaml" |
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
Thank you for the PR @mergenci, we need to backport the API changes in v1beta2 to v1beta1 here too :) It would also be good if we could test some of the resources we backported with uptest. |
mergenci
force-pushed
the
bump-upjet-be5e036
branch
2 times, most recently
from
4dbc47d to
f4a72b1
Compare
|
/test-examples="examples/ssm/v1beta2/maintenancewindowtask.yaml" |
|
/test-examples="examples/apigateway/v1beta2/restapi.yaml" |
|
/test-examples="examples/ssm/v1beta2/association.yaml" |
Signed-off-by: Cem Mergenci <[email protected]>
mergenci
force-pushed
the
bump-upjet-be5e036
branch
from
f4a72b1 to
9e4afbc
Compare
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
AutomationParametersParameterParameters type in v1beta1 corresponds to ParameterParameters type in v1beta2. It's not possible to "backport the name" of the v1beta1 type to ParameterParameters, because that name is already defined in Document resource (in zz_document_types.go file) in v1beta1 package. Changes in such renamed types could be the most difficult to detect and handle automatically. Signed-off-by: Cem Mergenci <[email protected]>
Signed-off-by: Cem Mergenci <[email protected]>
There are no changes after `make generate`. Signed-off-by: Cem Mergenci <[email protected]>
`make generate` didn't output any changes. Signed-off-by: Cem Mergenci <[email protected]>
mergenci
force-pushed
the
bump-upjet-be5e036
branch
from
9e4afbc to
5821854
Compare
|
/test-examples="examples/dynamodb/v1beta1/table.yaml" |
|
/test-examples="examples/ec2/v1beta2/vpcendpoint.yaml" |
|
/test-examples="examples/s3/v1beta1/bucket.yaml" |
|
/test-examples="examples/apigateway/v1beta2/restapi.yaml" |
|
/test-examples="examples/ssm/v1beta2/association.yaml" |
Signed-off-by: Cem Mergenci <[email protected]>
Description of your changes
I would like to consume Upjet PRs that come before crossplane/upjet#424, so that changes because of those don't crowd #1422. This PR consumes the following (listed in chronological order of merging):
I have:
make reviewableto ensure this PR is ready for review.Addedbackport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Uptest runs:
Manual tests: