-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(SNS): add topic_arn to created secrets #1585
feat(SNS): add topic_arn to created secrets #1585
Conversation
67001dd
to
9b5c010
Compare
Signed-off-by: Pierre LEJEUNE <[email protected]>
9b5c010
to
3222f5a
Compare
Signed-off-by: Pierre Lejeune <[email protected]>
@jbw976 I've managed to build and test it and it worked: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @darkanakin41,
Thank you for your first contribution 🙂 I left a comment for you to consider. Also, I see in your explanations that you have successfully tested it. It would be great if you could share a screenshot that the arn came to the secret properly.
Hey @turkenf BTW, i've applied your suggestion |
ccd6f7c
to
d4189be
Compare
Co-authored-by: Fatih Türken <[email protected]> Signed-off-by: Pierre LEJEUNE <[email protected]>
d4189be
to
c24972a
Compare
/test-examples="examples/sns/v1beta1/topic.yaml" |
1 similar comment
/test-examples="examples/sns/v1beta1/topic.yaml" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @darkanakin41, LGTM.
Description of your changes
Fixes #1577: inject topic ARN in the secrets
I have:
make reviewable
to ensure this PR is ready for review.backport release-1.17
labels to auto-backport this PR if necessary.How has this code been tested
It was build and deploy to a test cluster. The resource was properly created and and the secret was set properly aswell: