Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SNS): add topic_arn to created secrets #1585

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

darkanakin41
Copy link
Contributor

@darkanakin41 darkanakin41 commented Dec 3, 2024

Description of your changes

Fixes #1577: inject topic ARN in the secrets

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-1.17 labels to auto-backport this PR if necessary.

How has this code been tested

It was build and deploy to a test cluster. The resource was properly created and and the secret was set properly aswell:

image

@darkanakin41 darkanakin41 force-pushed the aws_sns_arn_in_secrets branch 2 times, most recently from 67001dd to 9b5c010 Compare December 10, 2024 20:20
@darkanakin41 darkanakin41 force-pushed the aws_sns_arn_in_secrets branch from 9b5c010 to 3222f5a Compare December 10, 2024 20:21
@darkanakin41
Copy link
Contributor Author

darkanakin41 commented Dec 16, 2024

@jbw976 I've managed to build and test it and it worked:
image
Docker image: https://hub.docker.com/r/darkanakin41/provider-aws-sns/tags
I would love to have it backported to 1.17 but I cannot add the flag

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @darkanakin41,

Thank you for your first contribution 🙂 I left a comment for you to consider. Also, I see in your explanations that you have successfully tested it. It would be great if you could share a screenshot that the arn came to the secret properly.

config/sns/config.go Outdated Show resolved Hide resolved
@darkanakin41
Copy link
Contributor Author

darkanakin41 commented Dec 16, 2024

Hi @darkanakin41,

Thank you for your first contribution 🙂 I left a comment for you to consider. Also, I see in your explanations that you have successfully tested it. It would be great if you could share a screenshot that the arn came to the secret properly.

Hey @turkenf
The screenshot is in both the comment and the initial message (i've updated it this morning) but here it is again:
image
I've not displayed the value because it contains some work informations. But it you need to see the real value, not the encoded one, let me know :)

BTW, i've applied your suggestion

@darkanakin41 darkanakin41 force-pushed the aws_sns_arn_in_secrets branch from ccd6f7c to d4189be Compare December 16, 2024 19:32
Co-authored-by: Fatih Türken <[email protected]>

Signed-off-by: Pierre LEJEUNE <[email protected]>
@darkanakin41 darkanakin41 force-pushed the aws_sns_arn_in_secrets branch from d4189be to c24972a Compare December 16, 2024 19:33
@turkenf
Copy link
Collaborator

turkenf commented Dec 17, 2024

/test-examples="examples/sns/v1beta1/topic.yaml"

1 similar comment
@turkenf
Copy link
Collaborator

turkenf commented Dec 17, 2024

/test-examples="examples/sns/v1beta1/topic.yaml"

Copy link
Collaborator

@turkenf turkenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @darkanakin41, LGTM.

@turkenf turkenf merged commit 4bed0cf into crossplane-contrib:main Dec 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SNS Provider - Topic: feed the topicARN into secret
2 participants