-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes deps #630
Conversation
716b8b4
to
028ac9a
Compare
3f871ec
to
d1a773b
Compare
9f27180
to
c3e5a27
Compare
c3e5a27
to
d05b5c2
Compare
Co-authored-by: Maximilian Blatt <[email protected]> Signed-off-by: Philippe Scorsolini <[email protected]>
@@ -142,6 +142,24 @@ func (c *GVKRoutedCache) GetInformerForKind(ctx context.Context, gvk schema.Grou | |||
return c.fallback.GetInformerForKind(ctx, gvk, opts...) | |||
} | |||
|
|||
// RemoveInformer removes an informer entry and stops it if it was running. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sttts mind having a look at this as the original author of the rest of the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this new method needed to satisfy an updated interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Informers.
|
||
c.lock.RLock() | ||
delegate, ok := c.delegates[gvk] | ||
c.lock.RUnlock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this remove the delegate from the map?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know a way to determine if a delegate has any more informers. Would it hurt to just keep a delegate in any case?
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Successfully created backport PR for |
This PR contains the following updates:
v0.28.4
->v0.29.1
v0.28.4
->v0.29.1
v0.28.4
->v0.29.1
v0.28.4
->v0.29.1
v0.16.3
->v0.17.0
v0.13.0
->v0.14.0
Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
kubernetes/api (k8s.io/api)
v0.29.1
Compare Source
v0.29.0
Compare Source
v0.28.6
Compare Source
v0.28.5
Compare Source
kubernetes/apiextensions-apiserver (k8s.io/apiextensions-apiserver)
v0.29.1
Compare Source
v0.29.0
Compare Source
v0.28.6
Compare Source
v0.28.5
Compare Source
kubernetes/apimachinery (k8s.io/apimachinery)
v0.29.1
Compare Source
v0.29.0
Compare Source
v0.28.6
Compare Source
v0.28.5
Compare Source
kubernetes/client-go (k8s.io/client-go)
v0.29.1
Compare Source
v0.29.0
Compare Source
v0.28.6
Compare Source
v0.28.5
Compare Source
kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)
v0.17.0
Compare Source
✨ New Features
🐛 Bug Fixes
RemoveControllerReference
andHasControllerReference
func (#2509 #2595)RemoveOwnerReference
func (#2462)🌱 Others
🌱 Dependencies
📖 Additionally, there have been 5 contributions to our documentation. (#2497, #2498, #2538, #2599, #2602, #2635 #2647)
Thanks to all our contributors! 😊
kubernetes-sigs/controller-tools (sigs.k8s.io/controller-tools)
v0.14.0
Compare Source
What's Changed
Dependency bumps
New Contributors
Full Changelog: kubernetes-sigs/controller-tools@v0.13.0...v0.14.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate. View repository job log here.