Switch from Makefile to Earthly #698
Conversation
Signed-off-by: Nic Cope <[email protected]>
Unmodified for now. I'll strip out everything this repo doesn't need in a follow-up commit. Signed-off-by: Nic Cope <[email protected]>
Removes all jobs and targets that are specific to crossplane/crossplane. Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
This implies switching from the Renovate app to the Renovate action. Signed-off-by: Nic Cope <[email protected]>
This syncs with what we currently have in c/c. In practice we've dropped reviewers because everything blocks on reviewers. Signed-off-by: Nic Cope <[email protected]>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Changing this package would be a breaking change. Signed-off-by: Nic Cope <[email protected]>
Signed-off-by: Nic Cope <[email protected]>
negz
force-pushed
the
third-rock-from-the-sun
branch
from
1bd4996
to
e977812
Compare
There was a problem hiding this comment.
Took this for a quick test drive and all the commands I was running worked successfully! (+build, +reviewable, +test, +generate). Looks like we've incorporated a lot of the lessons from iterating on core crossplane too :)
Just a few questions, nothing blocking on my end!
| @@ -1,48 +0,0 @@ | |||
| name: Promote | |||
There was a problem hiding this comment.
this promote workflow was never used for crossplane-runtime, and therefore safe to delete?
There was a problem hiding this comment.
Yeah, exactly. I can't think of what it would have done.
| "regexManagers": [ | ||
| // The branches renovate should target | ||
| // PLEASE UPDATE THIS WHEN RELEASING. | ||
| "baseBranches": [ |
There was a problem hiding this comment.
oh interesting, we weren't specifying the set of baseBranches before now - consider making a small tweak to the instructions for updating baseBranches in https://github.com/crossplane/release/blob/main/.github/ISSUE_TEMPLATE/release.md, so we remember to update it here too in addition to core crossplane.
| @@ -0,0 +1,57 @@ | |||
| name: Renovate | |||
There was a problem hiding this comment.
wait, was Renovate not running on crossplane-runtime since switching to self hosted?
There was a problem hiding this comment.
I think it was still using the Renovate app. See for example #695 which was opened last week.
I'm guessing we should switch to self hosted for the same reasons as c/c though.
Description of your changes
We're trying out a new build tool for one release. See crossplane/crossplane#5711 for context.
I have:
earthly +reviewableto ensure this PR is ready for review.How has this code been tested
Just
earthly +reviewablefor now.