Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Handle Bing 400 error return empty output #66

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Handle Bing 400 error return empty output #66

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
277d73f
Handle Bing 400 error return empty output
VolkMilit Jan 5, 2024
2e046a0
Make it better
VolkMilit Jan 5, 2024
96fb8ed
Just check for statusCode instead of hard-coded check for 400 error
VolkMilit Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/qonlinetranslator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,16 @@ void QOnlineTranslator::parseBingTranslate()
const QJsonDocument jsonResponse = QJsonDocument::fromJson(m_currentReply->readAll());
const QJsonObject responseObject = jsonResponse.array().first().toObject();

if (!jsonResponse.object().value(QStringLiteral("statusCode")).isNull()) {
const QString errorMessage = jsonResponse.object().value(QStringLiteral("errorMessage")).toString();

if (!errorMessage.isEmpty())
resetData(ServiceError, errorMessage);
else
resetData(ServiceError, tr("Error: Bing return unhandled network error"));
return;
}

if (m_sourceLang == Auto) {
const QString langCode = responseObject.value(QStringLiteral("detectedLanguage")).toObject().value(QStringLiteral("language")).toString();
m_sourceLang = language(Bing, langCode);
Expand Down
Loading