Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FirstLineContainsHeader type from int to bool, update respective test cases #62

Merged

Conversation

jameskim0987
Copy link
Contributor

Fixes #61

Changes made in this PR:

  1. change type of FirstLineContainsHeader from int to bool
  2. update respective testcases ( TestTranslationMemoryService_ImportTM and TestTranslationMemoryService_CheckTMImportStatus ) to use and expect bool instead of int

@jameskim0987 jameskim0987 changed the title [ISSUE-61] Fix FirstLineContainsHeader type from int to bool, update respective test cases fix: [ISSUE-61] Fix FirstLineContainsHeader type from int to bool, update respective test cases Sep 25, 2024
@jameskim0987 jameskim0987 marked this pull request as ready for review September 25, 2024 19:50
@jameskim0987
Copy link
Contributor Author

Hi @andrii-bodnar @Multiply, this PR is ready for review

@andrii-bodnar andrii-bodnar changed the title fix: [ISSUE-61] Fix FirstLineContainsHeader type from int to bool, update respective test cases fix: FirstLineContainsHeader type from int to bool, update respective test cases Sep 26, 2024
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameskim0987 thanks a lot for the contribution!

@andrii-bodnar andrii-bodnar merged commit 4a5eaf9 into crowdin:main Sep 26, 2024
4 of 5 checks passed
@vorobeyme
Copy link
Contributor

Thanks for the contribution!
I just wanted to flag up the data.attributes.firstLineContainsHeader parameter. According to the API doc, it must be integer.

@andrii-bodnar, could you please confirm that it is always bool, int, or both?
If it's both, then we'll need to specify custom decoding from JSON to support all of them.

@andrii-bodnar
Copy link
Member

@vorobeyme it's some mistake in the API Docs (I see only one wrong integer example in the Check TM Import Status method). The firstLineContainsHeader is always boolean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TranslationMemoryImport.Attributes.FirstLineContainsHeader int vs bool
3 participants