enhancement/refactor: path handling #81
Labels
Comments
benatouba
added a commit
to benatouba/cosipy
that referenced
this issue
Nov 26, 2024
Transform all path variables to the more modern `pathlib.Path` object. This helps with cross-platform compatibility and makes the code more readable. Some type annotations were also passed. Meant to be applied in conjunction with a move to Pydantic for configuration validation. NOTE: If cherry-picked, needs to be revised carefully as the commit is meant to be applied with a move to Pydantic. Fixes cryotools#81
|
Links to #86. |
gampnico
added a commit
that referenced
this issue
Nov 29, 2024
benatouba
added a commit
to benatouba/cosipy
that referenced
this issue
Nov 29, 2024
Transform all path variables to the more modern `pathlib.Path` object. This helps with cross-platform compatibility and makes the code more readable. Some type annotations were also passed. Meant to be applied in conjunction with a move to Pydantic for configuration validation. NOTE: If cherry-picked, needs to be revised carefully as the commit is meant to be applied with a move to Pydantic. Fixes cryotools#81
benatouba
added a commit
to benatouba/cosipy
that referenced
this issue
Nov 29, 2024
Transform all path variables to the more modern `pathlib.Path` object. This helps with cross-platform compatibility and makes the code more readable. Some type annotations were also passed. Meant to be applied in conjunction with a move to Pydantic for configuration validation. NOTE: If cherry-picked, needs to be revised carefully as the commit is meant to be applied with a move to Pydantic. Fixes cryotools#81
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The file handling via the
os.pathmodule comes with several pitfalls, especially when dealing with bothUNIX-pathandntppathstyles. I am not sure if COSIPY is supposed to run on windows as well, but do you see a benefit in refactoring the code to usepathlibmodule'sPathandPurePathclasses for path-handling.It is encouraged to be used anyway, yields better type hinting, offers more flexibility with different systems and is arguably a bit prettier to write.
P.S.: I can't add labels to issues.
The text was updated successfully, but these errors were encountered: