Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor front-end #101

Merged
merged 2 commits into from
May 31, 2024
Merged

Refactor front-end #101

merged 2 commits into from
May 31, 2024

Conversation

guidanoli
Copy link
Contributor

Sorry for not being able to chop this PR into several smaller commits.
I'll highlight the most important changes:

  • Rename reader hooks (e.g. GetBounty ➡️ useBounty)
  • Rewrite reader hooks with useState, useEffect, safe JSON parsing, and type guards.
  • Render reader hooks in "loading" and "error" states.
  • Remove ethers from the list of dependencies, using viem instead

@guidanoli guidanoli requested a review from a team May 16, 2024 04:01
@guidanoli guidanoli self-assigned this May 16, 2024
@guidanoli guidanoli changed the title Feature/frontend refactor Refactor front-end May 16, 2024
@guidanoli guidanoli force-pushed the feature/frontend-refactor branch 2 times, most recently from 4878ed0 to 945fa6f Compare May 16, 2024 16:42
@guidanoli guidanoli force-pushed the feature/fix-eslintrc branch from 22a278d to 9769c14 Compare May 17, 2024 03:20
Base automatically changed from feature/fix-eslintrc to main May 17, 2024 03:20
@guidanoli guidanoli force-pushed the feature/frontend-refactor branch 4 times, most recently from 84fd94b to cf79d97 Compare May 17, 2024 04:41
@claudioantonio claudioantonio added this to the Testnet 2/2 milestone May 22, 2024
@guidanoli guidanoli force-pushed the feature/frontend-refactor branch from cf79d97 to bd0031d Compare May 22, 2024 19:34
@claudioantonio claudioantonio added the a-frontend Area: front-end label May 27, 2024
@guidanoli guidanoli force-pushed the feature/frontend-refactor branch from bd0031d to 3c4ffaa Compare May 28, 2024 18:36
@vercel Vercel
Copy link

vercel bot commented May 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bug-buster ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 28, 2024 6:37pm

claudioantonio
claudioantonio approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@claudioantonio claudioantonio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I passed thought the changes and did not see anything that caught my eyes and I also run it locally with no errors.
I loved to see that you removed the dependency for ethers because it was used only to execute vouchers! ❤️

@guidanoli guidanoli merged commit b7b48b2 into main May 31, 2024
2 checks passed
@guidanoli guidanoli deleted the feature/frontend-refactor branch May 31, 2024 02:00
claudioantonio pushed a commit that referenced this pull request Jun 1, 2024
@guidanoli @claudioantonio
Refactor front-end (#101)
22e1b38 
* Refactor front-end
* Remove `ethers`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudioantonio claudioantonio claudioantonio approved these changes

Assignees

@guidanoli guidanoli

Labels
a-frontend Area: front-end
Projects
None yet
Milestone
Testnet 2/2
Development

Successfully merging this pull request may close these issues.
2 participants
@guidanoli @claudioantonio